[BUGFIX] Use identifier_hash in CloudinaryScanService#38
Merged
dhuf merged 5 commits intotask/update-cloudinary-to-version-2from Nov 21, 2023
Merged
Conversation
The `fileExistsInStorage()` method currently performs a SQL query to count records, but suffers from slow performance due to the absence of an index on the `identifier` field. This results in a full table scan. To address this issue, this commit refactors the method to utilize the pre-existing `identifier_hash` field, specifically designed for efficient data searches.
dhuf
approved these changes
Nov 16, 2023
dhuf
force-pushed
the
fix/cloudinary-scan-service-full-table-scan
branch
7 times, most recently
from
7b20f50 to
c673899
Compare
dhuf
force-pushed
the
fix/cloudinary-scan-service-full-table-scan
branch
from
1e0cb08 to
7b877a3
Compare
SomeBdyElse
approved these changes
Nov 21, 2023
dhuf
added a commit
that referenced
this pull request
Dec 4, 2023
* [BUGFIX] Use identifier_hash in CloudinaryScanService The `fileExistsInStorage()` method currently performs a SQL query to count records, but suffers from slow performance due to the absence of an index on the `identifier` field. This results in a full table scan. To address this issue, this commit refactors the method to utilize the pre-existing `identifier_hash` field, specifically designed for efficient data searches. --------- Co-authored-by: Daniel Huf <daniel.huf@visol.ch> Co-authored-by: Hannes Lau <SomeBdyElse@users.noreply.github.com>
jrenggli
added a commit
that referenced
this pull request
Dec 5, 2023
* [BUGFIX] Use identifier_hash in CloudinaryScanService The `fileExistsInStorage()` method currently performs a SQL query to count records, but suffers from slow performance due to the absence of an index on the `identifier` field. This results in a full table scan. To address this issue, this commit refactors the method to utilize the pre-existing `identifier_hash` field, specifically designed for efficient data searches. --------- Co-authored-by: Daniel Huf <daniel.huf@visol.ch> Co-authored-by: Hannes Lau <SomeBdyElse@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
fileExistsInStorage()method currently performs a SQL query to count records, but suffers from slow performance due to the absence of an index on theidentifierfield. This results in a full table scan.To address this issue, this commit refactors the method to utilize the pre-existing
identifier_hashfield, specifically designed for efficient data searches.