fix(core): preserve object-form dock icons in command projection#378
Merged
Merged
Conversation
commit: |
Member
|
I think instead we should make the command to accept object shape icon |
Contributor
Author
|
I know, so we should first modify the type files in the devframe repository. I tried modifying it.devframes/devframe#32 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Vite+ icon not rendering correctly, Because the Vite+ dock icon is passed as an object. Since I’m not sure whether it was intended for future theme support, I avoided changing the registration and instead fixed
toCommand.Linked Issues
Additional context