feat(rsc): support stable inline action names - #1257
Closed
james-elicx wants to merge 2 commits into
Closed
Conversation
james-elicx
marked this pull request as ready for review
June 30, 2026 23:29
Contributor
|
I inferred the high level motivation of this PR as a following issue: I don't think hoisted function name is an actual requirement for this topic. Instead, the framework can generate a proper cache key and coordinate invalidation. Haven't fully fleshed out but I will try to illustrate the idea in #1411. Please let me know if I misread the context. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #1246.
Inline action hoist names are currently based on traversal order, so inserting an unrelated action renumbers existing server-reference IDs.
This adds an opt-in
stableNametransform option using a content-derived hash with duplicate disambiguation. Tests verify stability across unrelated insertions, changes when the function changes, and deterministic duplicate handling.