chore(rsc): add use cache example with closure encryption - #1398
Merged
Conversation
Co-authored-by: OpenCode <noreply@opencode.ai>
hi-ogawa
changed the title
use cache example with closure encryption
hi-ogawa
changed the title
use cache example with closure encryptionuse cache example with closure encryption
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Exclude React form transport fields from cache identity while preserving the original FormData for execution. Co-authored-by: OpenCode <noreply@opencode.ai>
hi-ogawa
commented
Aug 5, 2026
Co-authored-by: OpenCode <noreply@opencode.ai>
Keep FormData cache identity unchanged and point to custom form adaptation as the framework-level improvement path. Co-authored-by: OpenCode <noreply@opencode.ai>
Store the asynchronous encryption result in the envelope so the cache wrapper can inspect its sentinel without awaiting the argument. Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
hi-ogawa
marked this pull request as ready for review
August 5, 2026 09:06
hi-ogawa
commented
Aug 5, 2026
Comment on lines
+68
to
+73
| // TODO: On a cache miss, the hoister-generated implementation decrypts the | ||
| // original envelope again. A tighter adapter could reuse these captures. | ||
| const cacheArguments = [ | ||
| ...(await decryptCacheCaptures(firstArgument)), | ||
| ...admittedArgs.slice(1), | ||
| ] |
Contributor
Author
There was a problem hiding this comment.
To highlight the use server encryption parallel, this PR first lands with this approach. In principle, it's possible to decrypt once and reuse, which is deferred to follow-up PR #1403
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use cachewith closure encryption #1393use cachecan mostly reuse the existinguse serverclosure encryption machinery, but one twist is that the naive copy of implementation would make decryption inside the hoisted function happens too late and encrypted closure argument (which involves non-deterministics IV) would cause unstable cache key.This PR pre-decrypts closure captures when building the cache key. A framework-owned envelope provides a sentinel so the wrapper can distinguish encrypted closure-bound arguments from normal call arguments. This works with the existing encode/decode hooks and does not require new transform metadata, contrary to the issue’s initial framing.
The new example verifies stable cache identity across fresh ciphertext, different captured values producing different entries, and captured plaintext staying out of server responses.