Skip to content

feat(rsc): provide ast node value metadata in transformHoistInlineDirective + update example to exclude undeclared caller arguments for use cache cache keys (inline directive) - #1404

Merged
hi-ogawa merged 9 commits into
mainfrom
inline-cache-arguments
Aug 6, 2026
Merged

feat(rsc): provide ast node value metadata in transformHoistInlineDirective + update example to exclude undeclared caller arguments for use cache cache keys (inline directive)#1404
hi-ogawa merged 9 commits into
mainfrom
inline-cache-arguments

Conversation

@hi-ogawa

@hi-ogawa hi-ogawa commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

This PR updates the inline directive version of the callable "use cache" example to exclude extra caller arguments in the same way as the file directive case from #1401. To allow this, transformHoistInlineDirective now exposes the original function node to its runtime callback like transformWrapExport, which lets the example derive the declared argument count directly from node.params.

Co-authored-by: OpenCode <noreply@opencode.ai>
@hi-ogawa hi-ogawa changed the title feat(rsc): admit declared inline cache arguments chore(rsc): update example to exclude undeclared caller arguments for use cache cache keys (inline directive) Aug 5, 2026
@hi-ogawa hi-ogawa changed the title chore(rsc): update example to exclude undeclared caller arguments for use cache cache keys (inline directive) feat(rsc): support inline directive AST metadata and add use cache extra argument example Aug 5, 2026
@hi-ogawa hi-ogawa changed the title feat(rsc): support inline directive AST metadata and add use cache extra argument example feat(rsc): add function value metadata in transformHoistInlineDirective + update example to exclude undeclared caller arguments for use cache cache keys (inline directive) Aug 5, 2026
@hi-ogawa hi-ogawa changed the title feat(rsc): add function value metadata in transformHoistInlineDirective + update example to exclude undeclared caller arguments for use cache cache keys (inline directive) feat(rsc): provide ast node value metadata in transformHoistInlineDirective + update example to exclude undeclared caller arguments for use cache cache keys (inline directive) Aug 5, 2026
hi-ogawa and others added 8 commits August 5, 2026 19:06
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
@hi-ogawa
hi-ogawa marked this pull request as ready for review August 6, 2026 01:51
@hi-ogawa
hi-ogawa merged commit cd829da into main Aug 6, 2026
22 checks passed
@hi-ogawa
hi-ogawa deleted the inline-cache-arguments branch August 6, 2026 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exclude Undeclared Caller Arguments From "use cache" Cache Keys

1 participant