feat(rsc): provide ast node value metadata in transformHoistInlineDirective + update example to exclude undeclared caller arguments for use cache cache keys (inline directive) - #1404
Merged
Conversation
Co-authored-by: OpenCode <noreply@opencode.ai>
use cache cache keys (inline directive)
use cache cache keys (inline directive)use cache extra argument example
use cache extra argument exampletransformHoistInlineDirective + update example to exclude undeclared caller arguments for use cache cache keys (inline directive)
transformHoistInlineDirective + update example to exclude undeclared caller arguments for use cache cache keys (inline directive)transformHoistInlineDirective + update example to exclude undeclared caller arguments for use cache cache keys (inline directive)
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
Co-authored-by: OpenCode <noreply@opencode.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"use cache"Cache Keys #1392use cachecache keys (file directive only) #1401This PR updates the inline directive version of the callable
"use cache"example to exclude extra caller arguments in the same way as the file directive case from #1401. To allow this,transformHoistInlineDirectivenow exposes the original function node to its runtime callback liketransformWrapExport, which lets the example derive the declared argument count directly fromnode.params.