fix: disable hot reloading if in a WebWorker#181
Merged
Conversation
ArnaudBarre
reviewed
Jun 18, 2023
Member
ArnaudBarre
left a comment
There was a problem hiding this comment.
You need to also update the if statement for the footer
ArnaudBarre
approved these changes
Jun 19, 2023
Member
|
Thanks I will merge this later tonight, update the issues and release a new version |
Contributor
Author
|
Happy to help! |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related to issue #152 If React is used in a WebWorker (for instance when using a web worker to render static HTML),
plugin-reactwill error because of the use ofwindow, which is unavailable in WebWorkers. This patch disables hot reloading when in a WebWorker, which will hopefully prevent the crashes.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).