You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This types field is only used by (mostly deprecated) moduleResolution: "node". index.d.ts was same as index.d.mts previously, but unbuild 3.5.0 changed something and it's now index.d.cts for some reason. Making a quick fix to just point to index.d.mts to preserve old ts behavior.
Technically this should be reported and fixed on unbuild, but this types fields are only for back compat for ancient config, so quick fix on our side seems fine.
I locally confirmed the repro is fixed with local override.
I'm not really good at this madness of dual package, if it does not affect other module resolutions it should be a safe change then. Tagging the expert @bluwy
unbuild 3.5.0 changed something and it's now index.d.cts for some reason.
Haven't tested, but I noticed plugin-react 4.4.0 adds "type": "module" which changes how .d.ts gets evaluated. So that might've affected the output.
But anyways, I think this change is ok for compatibility. It changes the evaluation type from CJS to ESM (previous 4.3.4 evaluates as CJS), but this field is only used by moduleResolution: "node" which iirc doesn't care about evaluation type anyways.
The side-effect of using .d.mts though is that it's only supported since TypeScript 4.7, but it's an older release now and shouldn't affect most setup (similar bombshell-dev/clack#253)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
"moduleResolution": "node"in 4.4.0 #460This
typesfield is only used by (mostly deprecated)moduleResolution: "node".index.d.tswas same asindex.d.mtspreviously, butunbuild3.5.0 changed something and it's nowindex.d.ctsfor some reason. Making a quick fix to just point toindex.d.mtsto preserve old ts behavior.Technically this should be reported and fixed on
unbuild, but thistypesfields are only for back compat for ancient config, so quick fix on our side seems fine.I locally confirmed the repro is fixed with local override.