fix(build): declare moduleSideEffects for vite:modulepreload-polyfill#13099
Merged
patak-dev merged 4 commits intovitejs:mainfrom May 8, 2023
Merged
fix(build): declare moduleSideEffects for vite:modulepreload-polyfill#13099patak-dev merged 4 commits intovitejs:mainfrom
patak-dev merged 4 commits intovitejs:mainfrom
Conversation
|
|
cf92a99 to
88d64af
Compare
bluwy
reviewed
May 8, 2023
Member
bluwy
left a comment
There was a problem hiding this comment.
Seems like this is only caused because you've configured rollup with rollupOptions.treeshake.moduleSideEffects: false, but I don't think this addition hurts so sounds fine to me.
Member
There was a problem hiding this comment.
it doesn't look like this file is used. Could we remove it?
Contributor
Author
There was a problem hiding this comment.
Just removed it, I forgot to delete it.
Contributor
Author
|
|
0587617 to
cff99bf
Compare
patak-dev
reviewed
May 8, 2023
packages/vite/src/node/__tests__/plugins/modulePreloadPolyfill/modulePreloadPolyfill.spec.ts
Outdated
Show resolved
Hide resolved
bluwy
approved these changes
May 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
moduleSideEffects: trueproperty tovite:modulepreload-polyfill. The polyfill is effectful so it needs be declared as such otherwise it could be removed by Rollup.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).