fix(server): disable WebSocket server when server.hmr is false (#21041) #21253
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s#21041) When using the Environment API, setting `server.hmr: false` should fully disable the HMR pipeline, including preventing the WebSocket server from starting. However, Vite only checked `server.ws === false`, which caused the WS server to initialize even when HMR was disabled. This resulted in `EADDRINUSE` errors in monorepos and SSR environments that run multiple Vite instances in parallel (e.g., Nuxt). This change updates `createWebSocketServer()` to treat `server.hmr: false` as a hard disable for the WebSocket server, matching expected behavior and ensuring no WS port is opened when HMR is turned off. Fixes vitejs#21041.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the Environment API, setting
server.hmr: falseshould fully disable the HMR pipeline, including preventing the WebSocket server from starting. However, Vite only checkedserver.ws === false, which caused the WS server to initialize even when HMR was disabled.This resulted in
EADDRINUSEerrors in monorepos and SSR environments that run multiple Vite instances in parallel (e.g., Nuxt).This change updates
createWebSocketServer()to treatserver.hmr: falseas a hard disable for the WebSocket server, matching expected behavior and ensuring no WS port is opened when HMR is turned off.Fixes #21041.