Remove unnecessary port forwarding steps.#2749
Merged
thompsonja merged 1 commit intovitessio:masterfrom Apr 6, 2017
thompsonja:sandbox_ports
Merged
Remove unnecessary port forwarding steps.#2749thompsonja merged 1 commit intovitessio:masterfrom thompsonja:sandbox_ports
thompsonja merged 1 commit intovitessio:masterfrom
thompsonja:sandbox_ports
Conversation
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had forgotten that if I set the service type of a kubernetes service to LoadBalancer (which it is for vtgate/vtctld within the sandbox), then I don't need to forward a port. I'm keeping the port forwarding for the guestbook because the service is not currently configurable to be a LoadBalancer. This reduces the startup/teardown time by about a minute.
Also updated the sandbox configuration to have an explicit param for enabling the guestbook.
@wangyipei01, you'll have to update your resharding_sandbox.yaml configuration after I merge this PR.