MySQL binary protocol is done - fix doc to reflect this#3853
Merged
sougou merged 1 commit intovitessio:masterfrom Apr 21, 2018
Merged
MySQL binary protocol is done - fix doc to reflect this#3853sougou merged 1 commit intovitessio:masterfrom
sougou merged 1 commit intovitessio:masterfrom
Conversation
Contributor
|
I'm not sure I agree with discarding that doc entirely. Yes, mysql protocol is supported, but the RPC one supports a lot of features better, like bind variables... |
Contributor
|
LGTM after DCO / maybe squash. |
Signed-off-by: jvaidya <jitendra.vaidya@gmail.com>
jvaidya
force-pushed
the
fix_binary_proto_doc
branch
from
c6a7a61 to
e50cded
Compare
Contributor
Author
|
Squashed and DCO is also set. PTAL. |
alainjobart
approved these changes
Apr 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jvaidya jitendra.vaidya@gnail.com