Skip to content

refactor(coverage): move common parts to vitest package - #5236

Merged
sheremet-va merged 1 commit into
vitest-dev:mainfrom
AriPerkkio:refactor/reuse-coverage-logic
Feb 20, 2024
Merged

refactor(coverage): move common parts to vitest package#5236
sheremet-va merged 1 commit into
vitest-dev:mainfrom
AriPerkkio:refactor/reuse-coverage-logic

Conversation

@AriPerkkio

Copy link
Copy Markdown
Member

Description

Now that coverages packages don't have to maintain compatibility with previous vitest versions in same major (#5208), we can move more reusable code into vitest package. This is only refactoring to reduce duplication.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify

netlify Bot commented Feb 19, 2024

Copy link
Copy Markdown

Deploy Preview for fastidious-cascaron-4ded94 canceled.

Name Link
🔨 Latest commit ec40d70
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/65d38f4110b2e200089815e7

@hi-ogawa hi-ogawa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Just to confirm, is it intentional to not move magicast's parseModule to BaseCoverageProvider.updateThresholds? If we move it, then magicast dependency also has to go to main vitest package, so maybe that's a slight concern.

@AriPerkkio

Copy link
Copy Markdown
Member Author

Just to confirm, is it intentional to not move magicast's parseModule to BaseCoverageProvider.updateThresholds?

Yes exactly - we want to avoid having it as dependency on vitest package: #4442 (comment).
It cannot even be a devDependency for types: #4442 (comment).

@hi-ogawa

Copy link
Copy Markdown
Collaborator

Thanks for the links. Good to know it was already discussed before 👍

@sheremet-va
sheremet-va merged commit c692f76 into vitest-dev:main Feb 20, 2024
@AriPerkkio
AriPerkkio deleted the refactor/reuse-coverage-logic branch February 28, 2024 15:18
@AriPerkkio

AriPerkkio commented Feb 28, 2024

Copy link
Copy Markdown
Member Author

Now that breaking changes inside same major version are fine this kind of issues can come up #5310 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants