fix: remove vestigial spy stub, import directly from @vitest/spy
#7575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
mrginglymus
force-pushed
the
rm-spy-stub
branch
from
e54e213 to
d381d59
Compare
Contributor
Author
|
Ahh...not as vestigial as I'd hoped! |
Instead, import directly from @vitest/spy
mrginglymus
force-pushed
the
rm-spy-stub
branch
from
d381d59 to
ea597be
Compare
sheremet-va
approved these changes
Feb 27, 2025
jelmore1674
pushed a commit
to jelmore1674/build-changelog
that referenced
this pull request
Mar 19, 2025
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@vitest/coverage-v8](https://github.com/vitest-dev/vitest/tree/main/packages/coverage-v8#readme) ([source](https://github.com/vitest-dev/vitest/tree/HEAD/packages/coverage-v8)) | devDependencies | patch | [`3.0.7` -> `3.0.8`](https://renovatebot.com/diffs/npm/@vitest%2fcoverage-v8/3.0.7/3.0.8) | | [vitest](https://github.com/vitest-dev/vitest) ([source](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest)) | devDependencies | patch | [`3.0.7` -> `3.0.8`](https://renovatebot.com/diffs/npm/vitest/3.0.7/3.0.8) | --- ### Release Notes <details> <summary>vitest-dev/vitest (@​vitest/coverage-v8)</summary> ### [`v3.0.8`](https://github.com/vitest-dev/vitest/releases/tag/v3.0.8) [Compare Source](vitest-dev/vitest@v3.0.7...v3.0.8) ##### 🐞 Bug Fixes - Fix fetch cache multiple writes - by [@​hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7546 [<samp>(1a8b4)</samp>](vitest-dev/vitest@1a8b4337) - Use browser.isolate instead of config.isolate - by [@​sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7560 [<samp>(4b5ed)</samp>](vitest-dev/vitest@4b5ed902) - Remove vestigial spy stub, import directly from `@vitest/spy` - by [@​mrginglymus](https://github.com/mrginglymus) in vitest-dev/vitest#7575 [<samp>(7f7ff)</samp>](vitest-dev/vitest@7f7ff11c) - Correctly split the argv string - by [@​btea](https://github.com/btea) in vitest-dev/vitest#7533 [<samp>(4325a)</samp>](vitest-dev/vitest@4325ac67) - **browser**: - Remove [@​testing-library/dom](https://github.com/testing-library/dom) from dependencies - by [@​sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7555 [<samp>(5387a)</samp>](vitest-dev/vitest@5387a5b3) - Improve source map handling for bundled files - by [@​sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7534 [<samp>(e2c57)</samp>](vitest-dev/vitest@e2c570b6) - Print related test file and potential test in unhandled errors - by [@​sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7564 [<samp>(fee90)</samp>](vitest-dev/vitest@fee90d85) - **runner**: - Fix `beforeEach/All` cleanup callback timeout - by [@​hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7500 [<samp>(0c292)</samp>](vitest-dev/vitest@0c2924b7) - Fix and simplify `Task.suite` initialization - by [@​hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7414 [<samp>(ca9ff)</samp>](vitest-dev/vitest@ca9ffac5) - **snapshot**: - Allow inline snapshot calls on same location with same snapshot - by [@​jycouet](https://github.com/jycouet) and [@​hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7464 [<samp>(d5cb8)</samp>](vitest-dev/vitest@d5cb8212) - **vite-node**: - Fix `buildStart` on Vite 6 - by [@​hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7480 [<samp>(c0f47)</samp>](vitest-dev/vitest@c0f47e03) ##### [View changes on GitHub](vitest-dev/vitest@v3.0.7...v3.0.8) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xODguNCIsInVwZGF0ZWRJblZlciI6IjM5LjE4OC40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Reviewed-on: https://gitea.justinelmore.dev/jelmore1674/build-changelog/pulls/95 Co-authored-by: Renovate Bot <renovate-bot@forgejo.justinelmore.dev> Co-committed-by: Renovate Bot <renovate-bot@forgejo.justinelmore.dev>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
.d.tsfiles contain js code #7571The
integration/spy.tsfile has been vestigial since #2575. It seems to be confusingrollup-dts-plugin. Rather than bang our heads against a wall fixing that, remove it and just import/export from@vitest/spydirectly where referenced.This appears to fix the output
.d.tsfiles.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.