Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch contains a bugfix to DS2413.h, which is needed for one-wire actuators via DS2412 to work. Also, setup.html and script-setup.js are extended in order to work with DS2413 devices. I have tested the setup successfully with a single DS2413 (a BREWPI ONEWIRE SSR EXPANSION BOARD) that drives two SSRs.
setup.html and script-setup.js work fine with the new client under htmljs/src. I could not test them with the old client, which is shipped via the data_*.h files. Since the new client still is work in progress, I didn't commit any changes in the grunt configuration (which are tracked on my branch htmljs-development).