fix: remove duplicate Configure Alerts webhook block in Budget modal#368
Open
vivekchand wants to merge 1 commit intomainfrom
Open
fix: remove duplicate Configure Alerts webhook block in Budget modal#368vivekchand wants to merge 1 commit intomainfrom
vivekchand wants to merge 1 commit intomainfrom
Conversation
Duplicate Configure Alerts section (with duplicate IDs alert-webhook-url, alert-slack-url, alert-discord-url) caused getElementById to only find the first element, breaking webhook config save/load in the budget-tab-alerts panel. Removed the redundant second block (lines ~2859-2874).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two identical
Configure Alertssections existed in thebudget-tab-alertspanel with duplicate IDs:alert-webhook-urlalert-slack-urlalert-discord-urlThis caused
getElementByIdto silently use the first element only, breaking webhook config save/load — values entered in the second (visible) block were never read.Fix
Removed the duplicate block (18 lines). The first instance is retained; all JS references (
getElementById) now correctly target a single element.Testing
python3 -c "import dashboard; print('OK')"passes clean