[Kernel] Pipe attn_logits_soft_cap through paged attention TPU kernels#12294
[Kernel] Pipe attn_logits_soft_cap through paged attention TPU kernels#12294fenghuizhang wants to merge 0 commit intovllm-project:mainfrom
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
|
Can you add a correctness test for gemma in the ci so this codepath is flexed? Thanks! |
|
Ditto, LGTM when we can add test case to CI |
|
Thanks for the quick turnaround. I think CI (https://buildkite.com/vllm/fastcheck/builds/12156#01948bc4-58cd-4863-9eca-e2ea098879f9) exposed another issue in pt/xla code, I sent pytorch/xla#8600 to fix it and will verify things there first. Will come back to this PR afterwards. |
|
Local tests with the latest pt/xla code pass now, we may need to update the nightly build label for CI to pass: The error in https://buildkite.com/vllm/fastcheck/builds/12156#01948bc4-58cd-4863-9eca-e2ea098879f9 went away. |
Pipe attn_logits_soft_cap through paged_attention, this will unblock some of our models' adoption.
Note that the changed code currently doesn't have unit tests. I will add one later.
Signed-off-by: Fenghui Zhang fhzhang@google.com