Skip to content

[Frontend] Improve error message#31987

Merged
russellb merged 1 commit intovllm-project:mainfrom
DarkLight1337:sanitize-error
Jan 8, 2026
Merged

[Frontend] Improve error message#31987
russellb merged 1 commit intovllm-project:mainfrom
DarkLight1337:sanitize-error

Conversation

@DarkLight1337
Copy link
Copy Markdown
Member

@DarkLight1337 DarkLight1337 commented Jan 8, 2026

Purpose

Improve the error message that is returned to the client

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 requested a review from russellb January 8, 2026 17:50
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 8, 2026
@mergify mergify bot added the frontend label Jan 8, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request introduces a sanitize_message utility function to remove memory addresses from error messages, enhancing security by preventing information leaks. This function is correctly integrated into the API server's exception handlers for both HTTPException and RequestValidationError. A dedicated test case for the new utility function has also been added. The changes are well-implemented and directly address the stated purpose of improving error messages.

Copy link
Copy Markdown
Member

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@russellb russellb enabled auto-merge (squash) January 8, 2026 19:45
@russellb russellb merged commit aa125ec into vllm-project:main Jan 8, 2026
51 of 52 checks passed
yugong333 pushed a commit to yugong333/vllm that referenced this pull request Jan 9, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 deleted the sanitize-error branch January 9, 2026 02:43
akh64bit pushed a commit to akh64bit/vllm that referenced this pull request Jan 16, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
dsuhinin pushed a commit to dsuhinin/vllm that referenced this pull request Jan 21, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
ItzDEXX pushed a commit to ItzDEXX/vllm that referenced this pull request Feb 19, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
dtrifiro pushed a commit to dtrifiro/vllm that referenced this pull request Mar 9, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
dtrifiro added a commit to dtrifiro/vllm that referenced this pull request Mar 9, 2026
Fix:
GHSA-4r2x-xpjr-7cvv

- [Frontend] Improve error message (vllm-project#31987)
- [Frontend] Standardize use of `create_error_response` (vllm-project#32319)
- [Misc] Bump opencv-python dependecy version to 4.13 (vllm-project#32668)

https://issues.redhat.com/browse/INFERENG-4411
Shafi-Hussain pushed a commit to odh-on-pz/vllm-cpu that referenced this pull request Mar 17, 2026
Fix:
GHSA-4r2x-xpjr-7cvv

- [Frontend] Improve error message (vllm-project/vllm#31987)
- [Frontend] Standardize use of `create_error_response` (vllm-project/vllm#32319)
- [Misc] Bump opencv-python dependecy version to 4.13 (vllm-project/vllm#32668)

https://issues.redhat.com/browse/INFERENG-4411
https://issues.redhat.com/browse/RHOAIENG-48365
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants