Skip to content
This repository was archived by the owner on Oct 10, 2023. It is now read-only.

Bump kapp controller to version 0.28.0#1012

Merged
shivaani0505 merged 1 commit intomainfrom
shivaani/update-kapp-controller-28-tf
Nov 3, 2021
Merged

Bump kapp controller to version 0.28.0#1012
shivaani0505 merged 1 commit intomainfrom
shivaani/update-kapp-controller-28-tf

Conversation

@shivaani0505
Copy link
Copy Markdown
Contributor

@shivaani0505 shivaani0505 commented Oct 28, 2021

What this PR does / why we need it

  1. Bump kapp controller to version 0.28.0
  2. Disable metrics bind address

Which issue(s) this PR fixes

Fixes #961

Describe testing done for PR

Tested by generating kapp controller files for data values

Release note

Bump kapp controller to version 0.28.0

PR Checklist

  • Squash the commits into one or a small number of logical commits
  • Use good commit messages
  • Ensure PR contains terms all contributors can understand and links all contributors can access

Additional information

Special notes for your reviewer

Bolt MR needs to be created and build(bom) then checked with this PR

@shivaani0505 shivaani0505 requested a review from a team as a code owner October 28, 2021 20:16
@shivaani0505 shivaani0505 requested a review from shyaamsn October 28, 2021 20:17
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 28, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1012/20211028202624/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

vijaykatam
vijaykatam reviewed Oct 28, 2021
View reviewed changes
...ir/kapp-controller/_ytt_lib/addons/packages/kapp-controller/0.28.0/bundle/config/values.yaml
concurrency: 4
tolerations: []
apiPort: 10350
metricsBindAddress: ":8080"
Copy link
Copy Markdown
Contributor

@vijaykatam vijaykatam Oct 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since kapp-controller runs on host network and metrics doesn't require auth, I am thinking we have two options

  1. Limit to localhost.
  2. Disable

@cppforlife thoughts?

Copy link
Copy Markdown
Contributor

@vijaykatam vijaykatam Oct 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spoke too soon. This is vendir and we already disabled in

tanzu-framework/pkg/v1/providers/ytt/02_addons/kapp-controller/kapp-controller_addon_data.lib.yaml

Line 27 in aa1d2d7

metricsBindAddress: 0

Copy link
Copy Markdown

@cppforlife cppforlife Oct 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

vijaykatam
vijaykatam reviewed Oct 28, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@vijaykatam vijaykatam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cppforlife
Copy link
Copy Markdown

cppforlife commented Oct 28, 2021

lgtm

@vijaykatam vijaykatam added ok-to-merge PRs should be labelled with this before merging and removed ok-to-merge PRs should be labelled with this before merging labels Oct 28, 2021
@shivaani0505 shivaani0505 force-pushed the shivaani/update-kapp-controller-28-tf branch from aa1d2d7 to 96d1f72 Compare October 29, 2021 00:12
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 29, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1012/20211029002451/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@shivaani0505 shivaani0505 force-pushed the shivaani/update-kapp-controller-28-tf branch from 96d1f72 to 7c25dbb Compare October 29, 2021 17:21
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 29, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1012/20211029173208/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@shivaani0505
Copy link
Copy Markdown
Contributor Author

shivaani0505 commented Oct 30, 2021 •
edited
Loading

//usebom:sandbox/v1.5.0-zshippable/379645287599226148/tkg-compatibility

blc1996
blc1996 approved these changes Nov 1, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@blc1996 blc1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shivaani0505
Bump kapp controller to version 0.28.0
b0bf80d 
Signed-off-by: Shivaani Gupta <gshivaani@vmware.com>
@shivaani0505 shivaani0505 force-pushed the shivaani/update-kapp-controller-28-tf branch from 7c25dbb to b0bf80d Compare November 1, 2021 21:31
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 1, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1012/20211101214426/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@vijaykatam vijaykatam added the ok-to-merge PRs should be labelled with this before merging label Nov 2, 2021
@shivaani0505 shivaani0505 merged commit 3fc9916 into main Nov 3, 2021
@shivaani0505 shivaani0505 deleted the shivaani/update-kapp-controller-28-tf branch November 3, 2021 22:46
@rajaskakodkar rajaskakodkar mentioned this pull request Nov 22, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@shyaamsn shyaamsn Awaiting requested review from shyaamsn

3 more reviewers

@cppforlife cppforlife cppforlife left review comments

@vijaykatam vijaykatam vijaykatam approved these changes

@blc1996 blc1996 blc1996 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vijaykatam vijaykatam

Labels

area/addons cla-not-required ok-to-merge PRs should be labelled with this before merging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Upgrade kapp-controller to version 0.28.0 in tanzu-framework

5 participants

@shivaani0505 @cppforlife @vijaykatam @blc1996 @vmwclabot