Skip to content
This repository was archived by the owner on Oct 10, 2023. It is now read-only.

add dualstack feature flags#1013

Merged
adobley merged 1 commit intovmware-tanzu:mainfrom
adobley:dualstack-feature-gates
Nov 5, 2021
Merged

add dualstack feature flags#1013
adobley merged 1 commit intovmware-tanzu:mainfrom
adobley:dualstack-feature-gates

Conversation

@adobley
Copy link
Copy Markdown
Contributor

@adobley adobley commented Oct 28, 2021

What this PR does / why we need it

We have added four new feature flags for dualstack:
"features.management-cluster.dual-stack-ipv4-primary"
"features.management-cluster.dual-stack-ipv6-primary"
"features.workload-cluster.dual-stack-ipv4-primary"
"features.workload-cluster.dual-stack-ipv6-primary"

These features default to "false" and will need to be enabled for users
to use dualstack functionality while it is still under development.

Which issue(s) this PR fixes

Fixes #920

Describe testing done for PR

Tested combinations of the flag settings and TKG_IP_FAMILY configurations when running the tanzu commands to validate that the flags work as expected.

Release note

Experimental dual-stack functionality can be enabled with a feature flag.

PR Checklist

  • Squash the commits into one or a small number of logical commits
  • Use good commit messages
  • Ensure PR contains terms all contributors can understand and links all contributors can access

Additional information

Special notes for your reviewer

@adobley adobley requested a review from a team as a code owner October 28, 2021 22:56
@adobley adobley force-pushed the dualstack-feature-gates branch from 9e7014d to 87b939f Compare October 28, 2021 23:25
@github-actions
Copy link
Copy Markdown

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1013/20211028233713/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@adobley adobley force-pushed the dualstack-feature-gates branch from 87b939f to bfabe09 Compare October 29, 2021 16:55
@github-actions
Copy link
Copy Markdown

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1013/20211029170846/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@adobley
Copy link
Copy Markdown
Contributor Author

adobley commented Nov 3, 2021

Fixed a conflict.
@vmware-tanzu/tanzu-framework-reviewers Can someone take a look at this? It would be great to get this flag in.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 3, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1013/20211103175859/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@vuil vuil added area/networking ok-to-merge PRs should be labelled with this before merging labels Nov 5, 2021
Copy link
Copy Markdown
Contributor

@vuil vuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. I think the feature flag paths needs an update, but otherwise lgtm.

@vuil vuil self-assigned this Nov 5, 2021
@adobley adobley force-pushed the dualstack-feature-gates branch from 31e7f66 to b0e906d Compare November 5, 2021 17:29
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 5, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1013/20211105174323/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

Copy link
Copy Markdown
Contributor

@vuil vuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

We have added four new feature flags for dualstack:
"features.management-cluster.dual-stack-ipv4-primary"
"features.management-cluster.dual-stack-ipv6-primary"
"features.cluster.dual-stack-ipv4-primary"
"features.cluster.dual-stack-ipv6-primary"

These features default to "false" and will need to be enabled for users
to use dualstack functionality while it is still under development.

Signed-off-by: Edwin Xie <exie@vmware.com>
Co-authored-by: Aidan Obley <aobley@vmware.com>
Co-authored-by: Christian Ang <angc@vmware.com>
@adobley adobley force-pushed the dualstack-feature-gates branch from b0e906d to 66aab48 Compare November 5, 2021 18:32
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 5, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1013/20211105184559/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@adobley adobley merged commit 95c7834 into vmware-tanzu:main Nov 5, 2021
@adobley adobley deleted the dualstack-feature-gates branch November 5, 2021 20:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area/networking cla-not-required ok-to-merge PRs should be labelled with this before merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add CLI feature gate for dual stack management cluster and workload cluster creation

6 participants