Conversation
9e7014d to
87b939f
Compare
|
Cluster Generation A/B Results: |
87b939f to
bfabe09
Compare
|
Cluster Generation A/B Results: |
bfabe09 to
31e7f66
Compare
|
Fixed a conflict. |
|
Cluster Generation A/B Results: |
vuil
left a comment
There was a problem hiding this comment.
Thanks for the changes. I think the feature flag paths needs an update, but otherwise lgtm.
31e7f66 to
b0e906d
Compare
|
Cluster Generation A/B Results: |
We have added four new feature flags for dualstack: "features.management-cluster.dual-stack-ipv4-primary" "features.management-cluster.dual-stack-ipv6-primary" "features.cluster.dual-stack-ipv4-primary" "features.cluster.dual-stack-ipv6-primary" These features default to "false" and will need to be enabled for users to use dualstack functionality while it is still under development. Signed-off-by: Edwin Xie <exie@vmware.com> Co-authored-by: Aidan Obley <aobley@vmware.com> Co-authored-by: Christian Ang <angc@vmware.com>
b0e906d to
66aab48
Compare
|
Cluster Generation A/B Results: |
What this PR does / why we need it
We have added four new feature flags for dualstack:
"features.management-cluster.dual-stack-ipv4-primary"
"features.management-cluster.dual-stack-ipv6-primary"
"features.workload-cluster.dual-stack-ipv4-primary"
"features.workload-cluster.dual-stack-ipv6-primary"
These features default to "false" and will need to be enabled for users
to use dualstack functionality while it is still under development.
Which issue(s) this PR fixes
Fixes #920
Describe testing done for PR
Tested combinations of the flag settings and
TKG_IP_FAMILYconfigurations when running the tanzu commands to validate that the flags work as expected.Release note
PR Checklist
Additional information
Special notes for your reviewer