Skip to content
This repository was archived by the owner on Oct 10, 2023. It is now read-only.

Removed command to register and deregister the management cluster from TMC#1022

Merged
imikushin merged 1 commit intovmware-tanzu:mainfrom
saji-pivotal:saji/remove-tmc-registration
Nov 2, 2021
Merged

Removed command to register and deregister the management cluster from TMC#1022
imikushin merged 1 commit intovmware-tanzu:mainfrom
saji-pivotal:saji/remove-tmc-registration

Conversation

@saji-pivotal
Copy link
Copy Markdown
Contributor

Removed command to register and deregister the management cluster from TMC. Also removed other TMC references from the CLI code

Signed-off-by: Sudarshan asudarshan@vmware.com

What this PR does / why we need it

TMC is requiring an authenticated URL to fetch the yaml needed to register with TKG clusters. This adds unnecessary complexity to the TKG code. Further TMC has functionality on their side to register with TKG clusters, therefore it is not needed in the TKG code any more.

Which issue(s) this PR fixes

Fixes # #1021

Describe testing done for PR

  1. Created a workload cluster successfully to ensure that there are no regressions

Release note

Removes functionality for a TKG cluster to register to TMC using the Tanzu CLI

PR Checklist

  • Squash the commits into one or a small number of logical commits
  • Use good commit messages
  • Ensure PR contains terms all contributors can understand and links all contributors can access

Additional information

Special notes for your reviewer

@github-actions
Copy link
Copy Markdown

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1022/20211029225443/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@saji-pivotal saji-pivotal force-pushed the saji/remove-tmc-registration branch from ee7a2f8 to 5627dd8 Compare November 1, 2021 18:16
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 1, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1022/20211101182816/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@saji-pivotal saji-pivotal force-pushed the saji/remove-tmc-registration branch from 5627dd8 to c437682 Compare November 1, 2021 22:40
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 1, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1022/20211101225142/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@miclettej miclettej added area/cli area/ux UX related ok-to-merge PRs should be labelled with this before merging and removed cla-not-required ok-to-merge PRs should be labelled with this before merging labels Nov 2, 2021
…m TMC

Signed-off-by: Sudarshan <asudarshan@vmware.com>
@saji-pivotal saji-pivotal force-pushed the saji/remove-tmc-registration branch from c437682 to 2938d37 Compare November 2, 2021 17:34
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 2, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1022/20211102174504/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

Copy link
Copy Markdown
Contributor

@imikushin imikushin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imikushin imikushin added the ok-to-merge PRs should be labelled with this before merging label Nov 2, 2021
@imikushin imikushin merged commit 670dfcd into vmware-tanzu:main Nov 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area/cli area/ux UX related ok-to-merge PRs should be labelled with this before merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants