Skip to content
This repository was archived by the owner on Oct 10, 2023. It is now read-only.

Enable accelerated networking on Azure VMs by default where available#1025

Merged
vuil merged 1 commit intovmware-tanzu:mainfrom
stuartpreston:tkg-5867
Nov 3, 2021
Merged

Enable accelerated networking on Azure VMs by default where available#1025
vuil merged 1 commit intovmware-tanzu:mainfrom
stuartpreston:tkg-5867

Conversation

@stuartpreston
Copy link
Copy Markdown

@stuartpreston stuartpreston commented Oct 30, 2021

Signed-off-by: Stuart Preston spreston@vmware.com

What this PR does / why we need it

This PR re-enables Accelerated Networking in Azure by default for machines that support it. For a time (between April and June 2021) there was a problem with the networking kernel driver in Azure and as a reaction we disabled Accelerated Networking by default until new images were built that support it. It's now time to revert that.

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

  1. Inspected clustergen diff output
  2. Created cluster in Azure with new default value and machine type that has >4 CPU
  3. Verified

Release note

Azure VMs with 4 or more CPUs that support Accelerated Networking will now have this enabled by default.

PR Checklist

  • Squash the commits into one or a small number of logical commits
  • Use good commit messages
  • Ensure PR contains terms all contributors can understand and links all contributors can access

Additional information

Special notes for your reviewer

Signed-off-by: Stuart Preston <spreston@vmware.com>
@stuartpreston stuartpreston requested a review from a team as a code owner October 30, 2021 11:40
@github-actions
Copy link
Copy Markdown

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1025/20211030115233/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

Copy link
Copy Markdown
Contributor

@vuil vuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@vuil vuil added area/plugin ok-to-merge PRs should be labelled with this before merging labels Nov 3, 2021
@vuil vuil self-assigned this Nov 3, 2021
@vuil vuil merged commit c12f6ef into vmware-tanzu:main Nov 3, 2021
@vuil
Copy link
Copy Markdown
Contributor

vuil commented Nov 3, 2021

/test multi-version-install-azure

@alfredthenarwhal
Copy link
Copy Markdown

@vuil: /test multi-version-install-azure
Commit: 3e1d07c

Tests failed! Build no: 982

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area/plugin cla-not-required ok-to-merge PRs should be labelled with this before merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants