This repository was archived by the owner on Oct 10, 2023. It is now read-only.
update secret registry readme#1034
Merged
maralavi merged 2 commits intovmware-tanzu:mainfrom Nov 4, 2021
Merged
Conversation
Signed-off-by: Marjan Alavi <malavi@vmware.com>
maralavi
force-pushed
the
update-secret-registry-readme
branch
from
79b2c93 to
020b3bb
Compare
shivaani0505
reviewed
Nov 2, 2021
| ```sh | ||
| kubectl create namespace <NAMESPACE> | ||
| ``` | ||
|
|
Contributor
There was a problem hiding this comment.
Here we are mentioning 2 & 3 separately(only one way).
We can start by saying there are 2 ways of adding/exporting a secret after Step 1:
- 2& 3 separately ( where 2 adds secret and 3 updates secret by exporting to a diff namespace)
or
specify a single one line command for doing adding/exporting together
shivaani0505
reviewed
Nov 2, 2021
cmd/cli/plugin/secret/README.md
Outdated
| 3. In case you want to add the private repository in a different namespace than the namespace in which the secret was added to, you need o export the secret to all other namespaces. Please be aware that by doing so, the given secret contents will be available to ALL users in ALL namespaces. Please ensure that included registry credentials allow only read-only access to the registry with minimal necessary scope. You can export the secret to other namespaces by running: | ||
|
|
||
| ```sh | ||
| tanzu secret registry update <SECRET-NAME> --namespace <SECRET-NAMESPACE> --export-to-all-namespaces=true -y |
Contributor
There was a problem hiding this comment.
It would be nice to have the sample output of commands.When the doc writers try it out, they know they are going on right track by comparing the output
Contributor
|
Since in README , we have the topic heading which says "Workflow for adding a private package repository and installation of a private package", we should probably use something like below for release notes |
maralavi
force-pushed
the
update-secret-registry-readme
branch
from
24a557b to
5038fb4
Compare
shivaani0505
reviewed
Nov 3, 2021
cmd/cli/plugin/secret/README.md
Outdated
| Added registry secret '<SECRET-NAME>' into namespace '<SECRET-NAMESPACE>' | ||
| ``` | ||
|
|
||
| 3. In case you want to add the private repository in a different namespace than the namespace in which the secret was added to, you need o export the secret to all other namespaces. Please be aware that by doing so, the given secret contents will be available to ALL users in ALL namespaces. Please ensure that included registry credentials allow only read-only access to the registry with minimal necessary scope. You can export the secret to other namespaces using one of the followings: |
Contributor
There was a problem hiding this comment.
nitpick: followings => following
Signed-off-by: Marjan Alavi <malavi@vmware.com>
maralavi
force-pushed
the
update-secret-registry-readme
branch
from
5038fb4 to
bd45b36
Compare
shivaani0505
added
the
ok-to-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Describe testing done for PR:
Not applicable
Does this PR introduce a user-facing change?:
None
Release note:
New PR Checklist