Skip to content
This repository was archived by the owner on Oct 10, 2023. It is now read-only.

Add scaling support for TKGS v1alpha2 version#1045

Merged
prkalle merged 1 commit intovmware-tanzu:mainfrom
prkalle:fix/TKGS_nodepool_scale
Nov 8, 2021
Merged

Add scaling support for TKGS v1alpha2 version#1045
prkalle merged 1 commit intovmware-tanzu:mainfrom
prkalle:fix/TKGS_nodepool_scale

Conversation

@prkalle
Copy link
Copy Markdown
Contributor

@prkalle prkalle commented Nov 3, 2021

Signed-off-by: PremKumar Kalle pkalle@vmware.com

What this PR does / why we need it

Adding scaling suport for TKGS Tanzu Kubrenets clustre with v1alpha2 API version

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

-Created a workload cluster with dev plan and scale-up the cluster controlplane count and nodepool "workers" count successfully.

-Successfully scaled down the nodepool "Workers" replica count

Release note

Added scaling suport for TKGS Tanzu Kubrenets clustre with v1alpha2 API version

PR Checklist

  • Squash the commits into one or a small number of logical commits
  • Use good commit messages
  • Ensure PR contains terms all contributors can understand and links all contributors can access

Additional information

Special notes for your reviewer

@prkalle prkalle requested a review from tenczar November 3, 2021 01:16
@prkalle prkalle requested a review from a team as a code owner November 3, 2021 01:16
@prkalle prkalle force-pushed the fix/TKGS_nodepool_scale branch from 7b2e638 to 31717ea Compare November 3, 2021 01:26
@prkalle prkalle requested a review from saimanoj01 November 3, 2021 01:34
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 3, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1045/20211103013953/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

imikushin
imikushin reviewed Nov 5, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@imikushin imikushin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions.

@prkalle prkalle force-pushed the fix/TKGS_nodepool_scale branch 2 times, most recently from 7f21da4 to 86bd813 Compare November 8, 2021 15:15
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 8, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1045/20211108152452/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@prkalle
Add scaling support for TKGS v1alpha2 version
0552132 
Signed-off-by: PremKumar Kalle <pkalle@vmware.com>
@prkalle prkalle force-pushed the fix/TKGS_nodepool_scale branch from 86bd813 to 0552132 Compare November 8, 2021 15:36
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 8, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1045/20211108154611/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

imikushin
imikushin approved these changes Nov 8, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@imikushin imikushin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imikushin imikushin added the ok-to-merge PRs should be labelled with this before merging label Nov 8, 2021
@prkalle prkalle merged commit 71dc09a into vmware-tanzu:main Nov 8, 2021
yharish991 pushed a commit to yharish991/tanzu-framework that referenced this pull request Nov 9, 2021
@prkalle @yharish991
Add scaling support for TKGS v1alpha2 version (vmware-tanzu#1045)
4e1c688 
Signed-off-by: PremKumar Kalle <pkalle@vmware.com>
@rajaskakodkar rajaskakodkar mentioned this pull request Nov 22, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tenczar tenczar Awaiting requested review from tenczar

@saimanoj01 saimanoj01 Awaiting requested review from saimanoj01

1 more reviewer

@imikushin imikushin imikushin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tenczar tenczar

Labels

area/cli cla-not-required ok-to-merge PRs should be labelled with this before merging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@prkalle @imikushin @tenczar @vmwclabot