Skip to content
This repository was archived by the owner on Oct 10, 2023. It is now read-only.

Prevent Windows Updates by disabling the service#1083

Merged
vuil merged 1 commit intovmware-tanzu:mainfrom
stuartpreston:prevent_windows_updates
Nov 9, 2021
Merged

Prevent Windows Updates by disabling the service#1083
vuil merged 1 commit intovmware-tanzu:mainfrom
stuartpreston:prevent_windows_updates

Conversation

@stuartpreston
Copy link
Copy Markdown

@stuartpreston stuartpreston commented Nov 8, 2021

Signed-off-by: Stuart Preston spreston@vmware.com

What this PR does / why we need it

This PR prevents Windows Updates by disabling the service during the Kubeadm join. As we regularly build images with the latest Windows Updates, we should not be applying and rebooting any patches at runtime. The intended outcome of this PR is to lower the impact that rebooting the node has.

Which issue(s) this PR fixes

Fixes #977

Describe testing done for PR

  • Created Windows workload cluster with updated ytt
  • Verified existence of new files on a clean node
  • Verified execution of script and intended state of Windows service after a kubeadm join

image

Release note

Windows nodes will have their Windows Update service disabled to avoid unnecessary reboots.

PR Checklist

  • Squash the commits into one or a small number of logical commits
  • Use good commit messages
  • Ensure PR contains terms all contributors can understand and links all contributors can access

Additional information

Special notes for your reviewer

@stuartpreston stuartpreston requested a review from a team as a code owner November 8, 2021 13:39
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 8, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1083/20211108134818/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 9, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1083/20211109100058/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@randomvariable
Prevent Windows Updates by disabling the service
56626a3 
Signed-off-by: Stuart Preston <spreston@vmware.com>
Co-authored-by: Naadir Jeewa <naadir@randomvariable.co.uk>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 9, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1083/20211109100451/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@stuartpreston
Copy link
Copy Markdown
Author

stuartpreston commented Nov 9, 2021

Re-verified expected behavior with @randomvariable suggested change.

image

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 9, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1083/20211109102508/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@randomvariable randomvariable added the ok-to-merge PRs should be labelled with this before merging label Nov 9, 2021
@randomvariable randomvariable self-assigned this Nov 9, 2021
@randomvariable randomvariable removed the ok-to-merge PRs should be labelled with this before merging label Nov 9, 2021
@randomvariable randomvariable added the ok-to-merge PRs should be labelled with this before merging label Nov 9, 2021
@randomvariable
Copy link
Copy Markdown
Contributor

randomvariable commented Nov 9, 2021

gtg

vuil
vuil approved these changes Nov 9, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@vuil vuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@vuil vuil merged commit 2357299 into vmware-tanzu:main Nov 9, 2021
@stuartpreston stuartpreston deleted the prevent_windows_updates branch November 9, 2021 18:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@randomvariable randomvariable randomvariable left review comments

@knabben knabben knabben approved these changes

@vuil vuil vuil approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@randomvariable randomvariable

Labels

cla-not-required ok-to-merge PRs should be labelled with this before merging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Windows Update should be disabled on Windows workload clusters

5 participants

@stuartpreston @randomvariable @knabben @vuil @vmwclabot