Skip to content
This repository was archived by the owner on Oct 10, 2023. It is now read-only.

Support skip x509 check in UI when deploying to vSphere#1090

Merged
miclettej merged 2 commits intovmware-tanzu:mainfrom
miclettej:topic/miclettej/TF-1028
Nov 10, 2021
Merged

Support skip x509 check in UI when deploying to vSphere#1090
miclettej merged 2 commits intovmware-tanzu:mainfrom
miclettej:topic/miclettej/TF-1028

Conversation

@miclettej
Copy link
Copy Markdown
Contributor

@miclettej miclettej commented Nov 8, 2021

Provides an option in the UI to skip x509 check in UI when deploying to vSphere

*Note: User may still set environment variable VSPHERE_INSECURE=true. This would return insecure: true during the getVsphereThumbprint REST call, and the UI will avoid displaying the SSL thumbprint verification regardless of the Skip Verification checkbox in the UI being checked or not.

Which issue(s) this PR fixes

Fixes #1028

Describe testing done for PR

Built and ran CLI locally, tested UI interaction of bypassing x509 check and using default behavior against vCenter testbed. Confirmed that UI is writing VSPHERE_INSECURE to config file.

Release note

UI includes new checkbox to allow bypassing SSL Thumbprint Verification when connecting to your vCenter server

PR Checklist

  • Squash the commits into one or a small number of logical commits
  • Use good commit messages
  • Ensure PR contains terms all contributors can understand and links all contributors can access

Additional information

Special notes for your reviewer

Screen Shot 2021-11-08 at 9 26 34 AM

Screen Shot 2021-11-08 at 9 27 54 AM

@miclettej miclettej requested a review from a team as a code owner November 8, 2021 18:53
@miclettej miclettej changed the title [Draft] Support skip x509 check in UI when deploying to vSphere Support skip x509 check in UI when deploying to vSphere Nov 8, 2021
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 8, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1090/20211108190219/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@miclettej miclettej added area/ui Specific UI issue/enhancement kind/enhancement Categorizes issue or PR as related to an enhancement labels Nov 8, 2021
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 8, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1090/20211108194731/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 8, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1090/20211108195710/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@miclettej miclettej force-pushed the topic/miclettej/TF-1028 branch from 2bf82e7 to 240d942 Compare November 8, 2021 20:12
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 8, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1090/20211108201839/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 8, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1090/20211108212533/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 8, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1090/20211108223207/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 8, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1090/20211108225640/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 8, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1090/20211108230610/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 8, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1090/20211108233443/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 9, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1090/20211109173411/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 9, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1090/20211109180205/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 9, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1090/20211109210157/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 9, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1090/20211109214841/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 9, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1090/20211109220424/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 9, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1090/20211109221154/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@miclettej miclettej added the ok-to-merge PRs should be labelled with this before merging label Nov 9, 2021
@miclettej miclettej force-pushed the topic/miclettej/TF-1028 branch from 718242c to 560a5c9 Compare November 9, 2021 23:30
@miclettej miclettej requested review from a team November 9, 2021 23:30
@miclettej miclettej requested a review from a team as a code owner November 9, 2021 23:30
Copy link
Copy Markdown
Contributor

@vuil vuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think the description or tooltip can better convey that skip verification will also be employed during cluster creation or something like that, but otherwise lgtm

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 9, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1090/20211109234843/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@miclettej miclettej force-pushed the topic/miclettej/TF-1028 branch from e54e5bb to 3e9b1d5 Compare November 9, 2021 23:52
@github-actions
Copy link
Copy Markdown

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1090/20211110000621/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@miclettej miclettej merged commit 7b637c3 into vmware-tanzu:main Nov 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area/ui Specific UI issue/enhancement cla-not-required docs-triage-needed kind/enhancement Categorizes issue or PR as related to an enhancement ok-to-merge PRs should be labelled with this before merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support skip x509 check in UI when deploying to vSphere

5 participants