Skip to content
This repository was archived by the owner on Oct 10, 2023. It is now read-only.

update TKR,Capabilities, Features, FeatureGates to use v1 CRD#1092

Merged
yharish991 merged 4 commits intovmware-tanzu:mainfrom
yharish991:fixCapabilitiesCRDVersion
Nov 11, 2021
Merged

update TKR,Capabilities, Features, FeatureGates to use v1 CRD#1092
yharish991 merged 4 commits intovmware-tanzu:mainfrom
yharish991:fixCapabilitiesCRDVersion

Conversation

@yharish991
Copy link
Copy Markdown
Contributor

@yharish991 yharish991 commented Nov 8, 2021 •
edited
Loading

Signed-off-by: Harish Yayi yharish991@gmail.com

What this PR does / why we need it

This PR upgrades TKR,Capabilities, Features, FeatureGates, StorageClasses to use v1 CRD

Which issue(s) this PR fixes

Fixes #1097

Describe testing done for PR

  1. make build-install-cli-local
  2. tanzu management-cluster create -v 6 --dry-run
  3. Inspect for capabilities CRS

Release note

Update TKR, Capabilities, Features, FeatureGates to use v1 CustomResourceDefintion and StorageClasses for Kubernetes v1.22 compatibility

PR Checklist

  • Squash the commits into one or a small number of logical commits
  • Use good commit messages
  • Ensure PR contains terms all contributors can understand and links all contributors can access

Additional information

Special notes for your reviewer

@yharish991 yharish991 added the kind/bug PR/Issue related to a bug label Nov 8, 2021
@yharish991 yharish991 requested a review from a team as a code owner November 8, 2021 20:35
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 8, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1092/20211108204424/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

rajathagasthya
rajathagasthya reviewed Nov 8, 2021
View reviewed changes
Copy link
Copy Markdown

@rajathagasthya rajathagasthya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick question: are we updating Feature and FeatureGate CRDs in a separate PR?

@yharish991 yharish991 changed the title update capabilities ytt templates to upgrade Capabilities CRD version [WIP] update capabilities ytt templates to upgrade Capabilities CRD version Nov 8, 2021
@yharish991 yharish991 force-pushed the fixCapabilitiesCRDVersion branch from 7bc89ef to b3d7f16 Compare November 8, 2021 21:03
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 8, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1092/20211108211250/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@yharish991 yharish991 force-pushed the fixCapabilitiesCRDVersion branch from b3d7f16 to aee8493 Compare November 8, 2021 21:52
@yharish991 yharish991 changed the title [WIP] update capabilities ytt templates to upgrade Capabilities CRD version [WIP] update Capabilities, Features, FeatureGates CRD to v1 version Nov 8, 2021
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 8, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1092/20211108220112/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@yharish991 yharish991 changed the title [WIP] update Capabilities, Features, FeatureGates CRD to v1 version update Capabilities, Features, FeatureGates CRD to v1 version Nov 8, 2021
@yharish991 yharish991 changed the title update Capabilities, Features, FeatureGates CRD to v1 version update Capabilities, Features, FeatureGatesto use v1 CRD Nov 8, 2021
@yharish991 yharish991 force-pushed the fixCapabilitiesCRDVersion branch 2 times, most recently from 8f24fc6 to 82e438c Compare November 8, 2021 22:15
@yharish991 yharish991 changed the title update Capabilities, Features, FeatureGatesto use v1 CRD update Capabilities, Features, FeatureGates to use v1 CRD Nov 8, 2021
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 8, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1092/20211108222448/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 8, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1092/20211108222618/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

danniel1205
danniel1205 approved these changes Nov 8, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@danniel1205 danniel1205 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prkalle prkalle changed the title update Capabilities, Features, FeatureGates to use v1 CRD update TKR,Capabilities, Features, FeatureGates to use v1 CRD Nov 9, 2021
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 9, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1092/20211109011138/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@yharish991 yharish991 force-pushed the fixCapabilitiesCRDVersion branch from 48cbf94 to 6f4d1a8 Compare November 9, 2021 01:17
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 9, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1092/20211109013220/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@jmoroski jmoroski added the ok-to-merge PRs should be labelled with this before merging label Nov 9, 2021
@yharish991 yharish991 force-pushed the fixCapabilitiesCRDVersion branch from 6f4d1a8 to b76f249 Compare November 9, 2021 21:15
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 9, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1092/20211109213032/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

yharish991 and others added 3 commits November 9, 2021 18:16
@yharish991
update capabilities ytt templates to upgrade Capabilities CRD version…
95d0168 
… to v1

Signed-off-by: Harish Yayi <yharish991@gmail.com>
@yharish991
upgrade feature and featuregates CRD to v1
da2a5d5 
Signed-off-by: Harish Yayi <yharish991@gmail.com>
@prkalle @yharish991
update TKR,Cliplugin,Provider examples to use v1 CRD
89f0054 
Signed-off-by: PremKumar Kalle <pkalle@vmware.com>
@yharish991 yharish991 force-pushed the fixCapabilitiesCRDVersion branch from b76f249 to 89f0054 Compare November 9, 2021 23:16
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 9, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1092/20211109233212/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@ashish-amarnath
Copy link
Copy Markdown
Contributor

ashish-amarnath commented Nov 10, 2021

@yharish991 can you please incorporate changes in #1133 into this PR as well?

Update Azure storage class to v1 API
905311a 
Signed-off-by: Naadir Jeewa <jeewan@vmware.com>
@randomvariable randomvariable mentioned this pull request Nov 10, 2021
Closed
3 tasks
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 10, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1092/20211110174820/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@yharish991 yharish991 merged commit 6878da2 into vmware-tanzu:main Nov 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

4 more reviewers

@jmoroski jmoroski jmoroski approved these changes

@imikushin imikushin imikushin approved these changes

@danniel1205 danniel1205 danniel1205 approved these changes

@rajathagasthya rajathagasthya rajathagasthya approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmoroski jmoroski

Labels

cla-not-required kind/bug PR/Issue related to a bug ok-to-merge PRs should be labelled with this before merging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Upgrade Features, FeatureGates, Capabilities to use v1 CRD

8 participants

@yharish991 @ashish-amarnath @jmoroski @imikushin @danniel1205 @rajathagasthya @vmwclabot @prkalle