Enable feature flag for API driven CLIPlugin Discovery by anujc25 · Pull Request #1144 · vmware-tanzu/tanzu-framework

anujc25 · 2021-11-11T07:55:59Z

What this PR does / why we need it

Currently, the feature flag for API-driven CLIPlugin discovery also known as Context-Aware-Discovery is turned off by default.

This PR turns on this feature flag by default.

Changes:

Updates Makefile to add/update targets to build CLI with feature flag enabled
- Build time configuration variable ENABLE_CONTEXT_AWARE_PLUGIN_DISCOVERY to enable/disable context-aware discovery
- Added config variable DEFAULT_STANDALONE_DISCOVERY_TYPE to use local/oci discovery type when building CLI
Local build for the development purpose, publishes the plugin discovery yamls and distribution artifacts to local discovery and uses that when doing plugin operations
Test plugins and Plugin Tests pipeline still uses non-context-aware discovery for testing

Bug Fixes:

Fix the populateStandaloneDiscovery logic (To not add additional default discovery if one already exists)
Show warning instead of error when a discovery failure. So that tanzu plugin list etc operation can report correct status
Do not throw error when catalog cache file doesn't exist on tanzu plugin clean

NOTE: Developers using the pre-release CLI, might have the feature flag disabled in the config file and might have to enable it manually by running tanzu config set features.global.context-aware-discovery true once. Because the previous default value of the flag was false

Which issue(s) this PR fixes

Fixes #1150

Describe testing done for PR

Tested plugins sync, install, list commands with local, oci discovery
Tested the management-cluster creation with local,oci discovery

Release note

Enabled API-driven CLIPlugin discovery by default. The change makes tanzu CLI context-aware

PR Checklist

Squash the commits into one or a small number of logical commits
Use good commit messages
Ensure PR contains terms all contributors can understand and links all contributors can access

Additional information

Special notes for your reviewer

github-actions · 2021-11-11T08:10:35Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1144/20211111081031/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2021-11-11T09:18:31Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1144/20211111091829/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2021-11-11T09:38:44Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1144/20211111093843/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2021-11-11T10:00:41Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1144/20211111100039/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2021-11-11T19:24:59Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1144/20211111192457/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2021-11-11T19:44:31Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1144/20211111194429/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2021-11-11T19:52:05Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1144/20211111195204/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2021-11-11T20:28:02Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1144/20211111202759/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2021-11-12T05:36:36Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1144/20211112053634/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2021-11-15T00:41:08Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1144/20211115004106/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2021-11-15T08:19:07Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1144/20211115081905/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2021-11-15T15:52:15Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1144/20211115155213/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

pkg/v1/config/clientconfig.go

pkg/v1/cli/pluginmanager/manager.go

github-actions · 2021-11-15T20:18:38Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1144/20211115201836/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

pkg/v1/cli/pluginmanager/manager.go

pkg/v1/config/discovery.go

pkg/v1/tkg/client/upgrade_region.go

github-actions · 2021-11-16T01:04:12Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1144/20211116010411/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2021-11-16T01:08:57Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1144/20211116010855/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

imikushin

Except for a few microscopic comments, looks great!

pkg/v1/cli/pluginmanager/manager.go

pkg/v1/config/discovery.go

github-actions · 2021-11-16T02:23:23Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1144/20211116022321/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

.github/workflows/plugin_tests.yaml

Makefile

docs/dev/build.md

vuil

lgtm, some minor typographical stuff, feel free to address as a followup.

Also, another nit: it wasn't perfect before, but all the new makefile targets have turned
make build-<tab> output quite menacing :-)
and introduced a bunch of misalignments in the
make help output

github-actions · 2021-11-16T07:27:38Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1144/20211116072736/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

- Enables the API-driven CLI plugin discovery by default - Update the Makefile to support local development workflow

- Refactor the populate default standalone discovery logic - Update default local discovery name to 'default-local'

…cli-for-plugins'

github-actions · 2021-11-16T23:45:50Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1144/20211116234548/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

anujc25 requested review from a team and miclettej as code owners November 11, 2021 07:56

vmwclabot added the cla-not-required label Nov 11, 2021

anujc25 marked this pull request as draft November 11, 2021 09:01

anujc25 force-pushed the turn-on-cliplugin-discovery branch from c0f4c8f to 283d4f2 Compare November 11, 2021 09:02

anujc25 force-pushed the turn-on-cliplugin-discovery branch from 283d4f2 to 377c87f Compare November 11, 2021 09:21

anujc25 force-pushed the turn-on-cliplugin-discovery branch from 377c87f to 54ac182 Compare November 11, 2021 09:43

anujc25 force-pushed the turn-on-cliplugin-discovery branch from 54ac182 to f1796f1 Compare November 11, 2021 19:09

anujc25 force-pushed the turn-on-cliplugin-discovery branch from f1796f1 to 33411f2 Compare November 11, 2021 19:29

anujc25 changed the title ~~[WIP] Turn on feature flag for API driven CLIPlugin Discovery~~ Turn on feature flag for API driven CLIPlugin Discovery Nov 11, 2021

anujc25 added area/cli area/plugin kind/feature Categorizes issue or PR as related to a new feature labels Nov 11, 2021

anujc25 marked this pull request as ready for review November 11, 2021 23:08

anujc25 force-pushed the turn-on-cliplugin-discovery branch from ab9c7da to 98ceae9 Compare November 12, 2021 05:20

anujc25 changed the title ~~Turn on feature flag for API driven CLIPlugin Discovery~~ Enable feature flag for API driven CLIPlugin Discovery Nov 12, 2021

anujc25 commented Nov 15, 2021

View reviewed changes

pkg/v1/config/clientconfig.go Show resolved Hide resolved

swalner-vmware reviewed Nov 15, 2021

View reviewed changes

pkg/v1/cli/pluginmanager/manager.go Outdated Show resolved Hide resolved

imikushin reviewed Nov 15, 2021

View reviewed changes

anujc25 force-pushed the turn-on-cliplugin-discovery branch 2 times, most recently from e438f61 to 37683e9 Compare November 16, 2021 01:02

imikushin approved these changes Nov 16, 2021

View reviewed changes

pkg/v1/cli/pluginmanager/manager.go Outdated Show resolved Hide resolved

pkg/v1/cli/pluginmanager/manager.go Outdated Show resolved Hide resolved

pkg/v1/config/discovery.go Outdated Show resolved Hide resolved

pkg/v1/config/discovery.go Outdated Show resolved Hide resolved

anujc25 force-pushed the turn-on-cliplugin-discovery branch from 37683e9 to 01fe5b1 Compare November 16, 2021 02:16

vuil reviewed Nov 16, 2021

View reviewed changes

.github/workflows/plugin_tests.yaml Outdated Show resolved Hide resolved

Makefile Outdated Show resolved Hide resolved

docs/dev/build.md Outdated Show resolved Hide resolved

vuil approved these changes Nov 16, 2021

View reviewed changes

anujc25 force-pushed the turn-on-cliplugin-discovery branch from 01fe5b1 to 25f2644 Compare November 16, 2021 07:21

Anuj Chaudhari added 7 commits November 16, 2021 15:30

Turn on CLIPlugin discovery by default and update Makefile

38fdbc5

- Enables the API-driven CLI plugin discovery by default - Update the Makefile to support local development workflow

Refactor and fix populate default standalone discovery logic

4c89303

- Refactor the populate default standalone discovery logic - Update default local discovery name to 'default-local'

Wait for core-management-plugins package

fec6f46

Show warning instead of error on discovery failure

57fc366

Do not throw error if catalog cache doesn't exist

7a02de8

Rename feature-flag from 'context-aware-discovery' to 'context-aware-…

42b969a

…cli-for-plugins'

Include Plan information as part of management-cluster get output

cb07e60

anujc25 force-pushed the turn-on-cliplugin-discovery branch from 25f2644 to cb07e60 Compare November 16, 2021 23:30

vuil added the ok-to-merge PRs should be labelled with this before merging label Nov 17, 2021

anujc25 merged commit 304e838 into vmware-tanzu:main Nov 17, 2021

This was referenced Nov 17, 2021

Add documentation regarding API-driven plugin discovery #1188

Merged

Add install scripts #1157

Merged

Release artifacts validation #1156

Merged

zjs mentioned this pull request Nov 18, 2021

The CLI should be able to download plugins from a registry requiring authentication #1208

Open

rajaskakodkar mentioned this pull request Nov 22, 2021

Update BoM retrieval version to 0.11.1 rajaskakodkar/tanzu-framework#1

Closed

stmcginnis mentioned this pull request Mar 5, 2022

Makefile missing build-cli-oci-* targets #1791

Closed

10 tasks

Conversation

anujc25 commented Nov 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this PR does / why we need it

Which issue(s) this PR fixes

Describe testing done for PR

Release note

PR Checklist

Additional information

Special notes for your reviewer

Uh oh!

github-actions bot commented Nov 11, 2021

Uh oh!

github-actions bot commented Nov 11, 2021

Uh oh!

github-actions bot commented Nov 11, 2021

Uh oh!

github-actions bot commented Nov 11, 2021

Uh oh!

github-actions bot commented Nov 11, 2021

Uh oh!

github-actions bot commented Nov 11, 2021

Uh oh!

github-actions bot commented Nov 11, 2021

Uh oh!

github-actions bot commented Nov 11, 2021

Uh oh!

github-actions bot commented Nov 12, 2021

Uh oh!

github-actions bot commented Nov 15, 2021

Uh oh!

github-actions bot commented Nov 15, 2021

Uh oh!

github-actions bot commented Nov 15, 2021

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 15, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 16, 2021

Uh oh!

github-actions bot commented Nov 16, 2021

Uh oh!

imikushin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 16, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vuil left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 16, 2021

Uh oh!

github-actions bot commented Nov 16, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

anujc25 commented Nov 11, 2021 •

edited

Loading