Skip to content
This repository was archived by the owner on Oct 10, 2023. It is now read-only.

set priorityClassName: system-node-critical in CPI daemonset#1149

Merged
vijaykatam merged 1 commit intovmware-tanzu:mainfrom
nicolehanjing:topic/nicoleh/fix-cpi-label
Nov 15, 2021
Merged

set priorityClassName: system-node-critical in CPI daemonset#1149
vijaykatam merged 1 commit intovmware-tanzu:mainfrom
nicolehanjing:topic/nicoleh/fix-cpi-label

Conversation

@nicolehanjing
Copy link
Copy Markdown
Contributor

@nicolehanjing nicolehanjing commented Nov 11, 2021 •
edited
Loading

What this PR does / why we need it

set priorityClassName: system-node-critical in CPI daemonset

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

generating CPI configs for data values

Release note

set priorityClassName: system-node-critical in CPI daemonset

PR Checklist

  • Squash the commits into one or a small number of logical commits
  • Use good commit messages
  • Ensure PR contains terms all contributors can understand and links all contributors can access

Additional information

Special notes for your reviewer

@nicolehanjing nicolehanjing requested a review from a team as a code owner November 11, 2021 19:16
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 11, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1149/20211111193153/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@nicolehanjing nicolehanjing changed the title set priorityClassName: system-cluster-critical in CPI daemonset set priorityClassName: system-node-critical in CPI daemonset Nov 11, 2021
@nicolehanjing nicolehanjing force-pushed the topic/nicoleh/fix-cpi-label branch from c73a856 to d0d7e50 Compare November 11, 2021 20:51
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 11, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1149/20211111210647/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@nicolehanjing nicolehanjing force-pushed the topic/nicoleh/fix-cpi-label branch from d0d7e50 to c6706a0 Compare November 12, 2021 00:08
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 12, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1149/20211112002442/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@nicolehanjing nicolehanjing force-pushed the topic/nicoleh/fix-cpi-label branch from c6706a0 to 75c4d7d Compare November 12, 2021 01:06
@nicolehanjing
Copy link
Copy Markdown
Contributor Author

nicolehanjing commented Nov 12, 2021

@vijaykatam Can I get a review when you get a chance? Thank you!

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 12, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1149/20211112012206/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@nicolehanjing nicolehanjing force-pushed the topic/nicoleh/fix-cpi-label branch from 75c4d7d to 854eb34 Compare November 15, 2021 18:11
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 15, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1149/20211115182743/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@vijaykatam vijaykatam added the ok-to-merge PRs should be labelled with this before merging label Nov 15, 2021
@vijaykatam vijaykatam merged commit ceae47d into vmware-tanzu:main Nov 15, 2021
@rajaskakodkar rajaskakodkar mentioned this pull request Nov 22, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@vijaykatam vijaykatam vijaykatam approved these changes

@lubronzhan lubronzhan lubronzhan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-not-required ok-to-merge PRs should be labelled with this before merging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nicolehanjing @vijaykatam @lubronzhan @vmwclabot