Add cert-manager templates to providers#1162
Add cert-manager templates to providers#1162saimanoj01 merged 2 commits intovmware-tanzu:mainfrom saimanoj01:cert_manager_fix
Conversation
|
Cluster Generation A/B Results: |
|
Cluster Generation A/B Results: |
|
Cluster Generation A/B Results: |
|
Cluster Generation A/B Results: |
anujc25
left a comment
There was a problem hiding this comment.
Is the addition of pkg/v1/tkg/fakes/providers/providers.zip file intentional? Is it getting used for unit tests?
Otherwise LGTM
|
@anujc25 Yes, that was intentional. I modified it for the sake of unit tests. Thanks |
|
Cluster Generation A/B Results: |
imikushin
left a comment
There was a problem hiding this comment.
Thanks for addressing my comments! Just one small detail and it's good to go.
|
Cluster Generation A/B Results: |
|
Cluster Generation A/B Results: |
|
Cluster Generation A/B Results: |
What this PR does / why we need it
In CAPI v1.0.0, it moved away from relying on a packaged version of cert-manager manifests during management cluster creation. Instead it is pulling the cert-manager manifest from github. This change ensures that CAPI uses the cert-manager manifests packaged along with the providers instead of pulling from github.
Which issue(s) this PR fixes
Fixes #1114
Describe testing done for PR
~/config/tanzu/tkgdirectory and successfully created a management cluster. Made sure that the cert-manager image is being pulled from the tkg registry.Release note
PR Checklist
Additional information
Special notes for your reviewer