This repository was archived by the owner on Oct 10, 2023. It is now read-only.
Fix issue where azure management cluster identity secret is not moved…#1182
Merged
prkalle merged 1 commit intovmware-tanzu:mainfrom Nov 17, 2021
Merged
Conversation
saimanoj01
reviewed
Nov 16, 2021
|
Cluster Generation A/B Results: |
… from bootstrap cluster to actual cluster Signed-off-by: PremKumar Kalle <pkalle@vmware.com>
74f2a8a to
39eba36
Compare
|
Cluster Generation A/B Results: |
saimanoj01
approved these changes
Nov 16, 2021
Contributor
saimanoj01
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the changes
anujc25
approved these changes
Nov 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… from bootstrap cluster to actual cluster
Signed-off-by: PremKumar Kalle pkalle@vmware.com
What this PR does / why we need it
This PR address the issue where the azure management cluster status is shown as
createStalledbecause the identity secret is not moved from bootstrap cluster to the actual management cluster during pivot operation.Which issue(s) this PR fixes
Fixes # #1186
Describe testing done for PR
Created Azure management cluster and also varified the identity secret is moved from bootstrap cluster to actual management cluster. The management cluster status now shows the status as running vs createStalled before the fix.
Release note
PR Checklist
Additional information
Special notes for your reviewer