Skip to content
This repository was archived by the owner on Oct 10, 2023. It is now read-only.

Fix issue where azure management cluster identity secret is not moved…#1182

Merged
prkalle merged 1 commit intovmware-tanzu:mainfrom
prkalle:fix/azure_identity_secret_move
Nov 17, 2021
Merged

Fix issue where azure management cluster identity secret is not moved…#1182
prkalle merged 1 commit intovmware-tanzu:mainfrom
prkalle:fix/azure_identity_secret_move

Conversation

@prkalle
Copy link
Copy Markdown
Contributor

@prkalle prkalle commented Nov 16, 2021

… from bootstrap cluster to actual cluster

Signed-off-by: PremKumar Kalle pkalle@vmware.com

What this PR does / why we need it

This PR address the issue where the azure management cluster status is shown as createStalled because the identity secret is not moved from bootstrap cluster to the actual management cluster during pivot operation.

$ tanzu cluster list --include-management-cluster
  NAME                           NAMESPACE   STATUS         CONTROLPLANE  WORKERS  KUBERNETES        ROLES       PLAN
  test-azure-tkr-prefixmatch-mc  tkg-system  createStalled  0/1           1/1      v1.21.5+vmware.1  management  dev

Which issue(s) this PR fixes

Fixes # #1186

Describe testing done for PR

Created Azure management cluster and also varified the identity secret is moved from bootstrap cluster to actual management cluster. The management cluster status now shows the status as running vs createStalled before the fix.

$ tanzu cluster list --include-management-cluster
  NAME                           NAMESPACE   STATUS   CONTROLPLANE  WORKERS  KUBERNETES        ROLES       PLAN
  test-azure-mccreatestalled-mc  tkg-system  running  1/1           1/1      v1.21.5+vmware.1  management  dev

Release note

Fixed issue where azure management cluster identity secret is not moved during pivot operation causing the incorrect cluster status

PR Checklist

  • Squash the commits into one or a small number of logical commits
  • Use good commit messages
  • Ensure PR contains terms all contributors can understand and links all contributors can access

Additional information

Special notes for your reviewer

@github-actions
Copy link
Copy Markdown

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1182/20211116211127/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

… from bootstrap cluster to actual cluster

Signed-off-by: PremKumar Kalle <pkalle@vmware.com>
@prkalle prkalle force-pushed the fix/azure_identity_secret_move branch from 74f2a8a to 39eba36 Compare November 16, 2021 21:50
@github-actions
Copy link
Copy Markdown

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1182/20211116220623/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

Copy link
Copy Markdown
Contributor

@saimanoj01 saimanoj01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the changes

@anujc25 anujc25 added area/cli kind/bug PR/Issue related to a bug ok-to-merge PRs should be labelled with this before merging labels Nov 17, 2021
@prkalle prkalle merged commit 5a0f710 into vmware-tanzu:main Nov 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area/cli cla-not-required kind/bug PR/Issue related to a bug ok-to-merge PRs should be labelled with this before merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants