Skip to content
This repository was archived by the owner on Oct 10, 2023. It is now read-only.

Fix the ip_family unit tests failed due to capv version bump#1402

Merged
prkalle merged 1 commit intovmware-tanzu:mainfrom
prkalle:fix/unit_test_fix_for_ipfamily
Dec 17, 2021
Merged

Fix the ip_family unit tests failed due to capv version bump#1402
prkalle merged 1 commit intovmware-tanzu:mainfrom
prkalle:fix/unit_test_fix_for_ipfamily

Conversation

@prkalle
Copy link
Copy Markdown
Contributor

@prkalle prkalle commented Dec 17, 2021

What this PR does / why we need it

This PR fixes the unit tests caused by capv version bump

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

Ran the unit tests and all the tests passed

Release note


PR Checklist

  • Squash the commits into one or a small number of logical commits
  • Use good commit messages
  • Ensure PR contains terms all contributors can understand and links all contributors can access

Additional information

Special notes for your reviewer

@prkalle prkalle requested review from anujc25 and miclettej December 17, 2021 03:05
@prkalle prkalle requested a review from a team as a code owner December 17, 2021 03:05
@prkalle prkalle added area/cli kind/failing-test Categorizes issue or PR as related to a failing test and removed cla-not-required labels Dec 17, 2021
@miclettej miclettej added the ok-to-merge PRs should be labelled with this before merging label Dec 17, 2021
@github-actions
Copy link
Copy Markdown

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1402/20211217031730/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@prkalle prkalle merged commit 81b9874 into vmware-tanzu:main Dec 17, 2021
@prkalle prkalle deleted the fix/unit_test_fix_for_ipfamily branch December 17, 2021 05:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area/cli kind/failing-test Categorizes issue or PR as related to a failing test ok-to-merge PRs should be labelled with this before merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants