Bump Antrea to Dragonfish.1 (1.2.3) by knabben · Pull Request #979 · vmware-tanzu/tanzu-framework

knabben · 2021-10-26T11:31:28Z

What this PR does / why we need it

Bumping Antrea Dragonfish.1

Which issue(s) this PR fixes

Describe testing done for PR

Release note

Antrea 1.2.3 support for ClusterResourceSet

PR Checklist

Squash the commits into one or a small number of logical commits
Use good commit messages
Ensure PR contains terms all contributors can understand and links all contributors can access

Additional information

Special notes for your reviewer

github-actions · 2021-10-26T11:41:50Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/979/20211026114148/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2021-10-26T11:45:14Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/979/20211026114512/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

knabben · 2021-10-26T11:47:12Z

/test install-vc7-windows

alfredthenarwhal · 2021-10-26T11:47:25Z

@knabben: /test install-vc7-windows

Tests can be triggered only by the trusted reviewers (users mentioned in CODEOWNERS file).

rajaskakodkar · 2021-10-26T11:48:15Z

/test install-vc7-windows

github-actions · 2021-10-26T11:54:03Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/979/20211026115402/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

pkg/v1/providers/infrastructure-vsphere/v0.7.10/ytt/overlay-windows.yaml

alfredthenarwhal · 2021-10-26T13:10:11Z

@rajaskakodkar: /test install-vc7-windows
Commit: a38ae0d

Tests failed! Build no: 898

hxietkg · 2021-10-26T13:40:12Z

@rajaskakodkar: /test install-vc7-windows
Commit: a38ae0d

Tests failed! Build no: 898

This is expected, DNS issue in Antrea 1.2.3 is not fixed yet.

...t/vendir/cni/_ytt_lib/addons/packages/antrea/1.2.3/bundle/config/overlay/antrea_overlay.yaml

pkg/v1/providers/ytt/vendir/cni/_ytt_lib/NOTICE

github-actions · 2021-10-27T23:02:18Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/979/20211027230217/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

vuil · 2021-10-28T17:24:26Z

@knabben can you file an issue and reference it in this PR's "Fixes:" section?
Also, what is DragonFish.1?
Would help to understand the reasoning behind the bump.

github-actions · 2021-10-30T14:33:35Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/979/20211030143333/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2021-11-01T15:49:55Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/979/20211101154953/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2021-11-01T16:05:54Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/979/20211101160553/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

knabben · 2021-11-01T16:33:00Z

//usebom

github-actions · 2021-11-05T19:44:04Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/979/20211105194402/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2021-11-05T20:13:56Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/979/20211105201354/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2021-11-08T13:37:04Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/979/20211108133702/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

jayunit100 · 2021-11-09T21:08:13Z

overall this lgtm. i think we should merge and iterate as needed. theres no way to 100% verify this by eye.

edwardbadboy · 2021-11-10T01:23:15Z

Looks good. Thanks.

vuil · 2021-11-10T01:26:55Z

So are the review comments addressed? Please resolve them if so.
Please review the last clustergen diffs:
#979 (comment)

jayunit100 · 2021-11-10T01:47:50Z

we can hold this until other dependencies merge... but... I think we just want a soft approval at this point.

The clustergendiff being empty I think is because this isn't integrated into the bom fully, so its effectively a no-op.

github-actions · 2021-11-10T10:35:21Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/979/20211110103520/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2021-11-10T22:05:54Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/979/20211110220552/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2021-11-11T02:11:42Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/979/20211111021140/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2021-11-11T20:27:17Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/979/20211111202715/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2021-11-12T14:02:23Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/979/20211112140221/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

knabben · 2021-11-15T14:54:07Z

@vijaykatam can you PTAL again?

vijaykatam

LGTM. Please have a networking team member sign off as well.

knabben · 2021-11-15T19:01:33Z

Looks good. Thanks.

@edwardbadboy is from Antrea team, could you approve on GH for the network team?

edwardbadboy · 2021-11-16T00:32:33Z

I didn't see an approve button or option. I'm not sure if it's because I don't have a privilege. From Antrea team's point of view I want to approve this patch.

knabben requested a review from a team as a code owner October 26, 2021 11:31

vmwclabot added the cla-not-required label Oct 26, 2021

knabben force-pushed the topic/knabben/bump-antrea-dragonfish branch from 8849dbf to 388e531 Compare October 26, 2021 11:32

knabben force-pushed the topic/knabben/bump-antrea-dragonfish branch from 388e531 to a38ae0d Compare October 26, 2021 11:43

hxietkg reviewed Oct 26, 2021

View reviewed changes

pkg/v1/providers/infrastructure-vsphere/v0.7.10/ytt/overlay-windows.yaml Outdated Show resolved Hide resolved

vijaykatam reviewed Oct 26, 2021

View reviewed changes

...t/vendir/cni/_ytt_lib/addons/packages/antrea/1.2.3/bundle/config/overlay/antrea_overlay.yaml Show resolved Hide resolved

...t/vendir/cni/_ytt_lib/addons/packages/antrea/1.2.3/bundle/config/overlay/antrea_overlay.yaml Outdated Show resolved Hide resolved

vuil added the ok-to-merge PRs should be labelled with this before merging label Oct 27, 2021

knabben force-pushed the topic/knabben/bump-antrea-dragonfish branch from a38ae0d to f13ee8a Compare October 27, 2021 22:49

knabben commented Oct 27, 2021

View reviewed changes

pkg/v1/providers/ytt/vendir/cni/_ytt_lib/NOTICE Show resolved Hide resolved

yharish991 assigned vijaykatam Oct 28, 2021

vijaykatam assigned jayunit100 and unassigned vijaykatam Oct 28, 2021

knabben force-pushed the topic/knabben/bump-antrea-dragonfish branch from f13ee8a to 3246296 Compare October 30, 2021 14:21

knabben force-pushed the topic/knabben/bump-antrea-dragonfish branch from 3246296 to 0726410 Compare November 1, 2021 15:38

knabben force-pushed the topic/knabben/bump-antrea-dragonfish branch from 0726410 to a144549 Compare November 1, 2021 15:54

vmware-tanzu deleted a comment from navidshaikh Nov 1, 2021

knabben force-pushed the topic/knabben/bump-antrea-dragonfish branch from 6581909 to f8e37af Compare November 5, 2021 19:30

knabben force-pushed the topic/knabben/bump-antrea-dragonfish branch from f8e37af to 36fa6ac Compare November 5, 2021 19:59

knabben force-pushed the topic/knabben/bump-antrea-dragonfish branch from 36fa6ac to 077482b Compare November 8, 2021 13:28

knabben force-pushed the topic/knabben/bump-antrea-dragonfish branch from 077482b to c5f2e5f Compare November 10, 2021 10:18

knabben force-pushed the topic/knabben/bump-antrea-dragonfish branch from c5f2e5f to 1f4d3cc Compare November 10, 2021 21:51

knabben force-pushed the topic/knabben/bump-antrea-dragonfish branch from 1f4d3cc to 48b8fde Compare November 11, 2021 01:58

knabben force-pushed the topic/knabben/bump-antrea-dragonfish branch from 48b8fde to cb6c391 Compare November 11, 2021 20:11

Antrea 1.2.3

a07d5de

knabben force-pushed the topic/knabben/bump-antrea-dragonfish branch from cb6c391 to a07d5de Compare November 12, 2021 13:45

vijaykatam approved these changes Nov 15, 2021

View reviewed changes

knabben changed the title ~~Antrea 1.2.3~~ Bump Antrea to Dragonfish.1 (1.2.3) Nov 15, 2021

jayunit100 assigned knabben Nov 16, 2021

knabben merged commit 12c11ea into vmware-tanzu:main Nov 16, 2021

rajaskakodkar mentioned this pull request Nov 22, 2021

Update BoM retrieval version to 0.11.1 rajaskakodkar/tanzu-framework#1

Closed

knabben deleted the topic/knabben/bump-antrea-dragonfish branch November 22, 2021 14:07

Conversation

knabben commented Oct 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this PR does / why we need it

Which issue(s) this PR fixes

Describe testing done for PR

Release note

PR Checklist

Additional information

Special notes for your reviewer

Uh oh!

github-actions bot commented Oct 26, 2021

Uh oh!

github-actions bot commented Oct 26, 2021

Uh oh!

knabben commented Oct 26, 2021

Uh oh!

alfredthenarwhal commented Oct 26, 2021

Uh oh!

rajaskakodkar commented Oct 26, 2021

Uh oh!

github-actions bot commented Oct 26, 2021

Uh oh!

Uh oh!

alfredthenarwhal commented Oct 26, 2021

Uh oh!

hxietkg commented Oct 26, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Oct 27, 2021

Uh oh!

vuil commented Oct 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 30, 2021

Uh oh!

github-actions bot commented Nov 1, 2021

Uh oh!

github-actions bot commented Nov 1, 2021

Uh oh!

knabben commented Nov 1, 2021

Uh oh!

github-actions bot commented Nov 5, 2021

Uh oh!

github-actions bot commented Nov 5, 2021

Uh oh!

github-actions bot commented Nov 8, 2021

Uh oh!

jayunit100 commented Nov 9, 2021

Uh oh!

edwardbadboy commented Nov 10, 2021

Uh oh!

vuil commented Nov 10, 2021

Uh oh!

jayunit100 commented Nov 10, 2021

Uh oh!

github-actions bot commented Nov 10, 2021

Uh oh!

github-actions bot commented Nov 10, 2021

Uh oh!

github-actions bot commented Nov 11, 2021

Uh oh!

github-actions bot commented Nov 11, 2021

Uh oh!

github-actions bot commented Nov 12, 2021

Uh oh!

knabben commented Nov 15, 2021

Uh oh!

vijaykatam left a comment

Choose a reason for hiding this comment

Uh oh!

knabben commented Nov 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

edwardbadboy commented Nov 16, 2021

Uh oh!

Reviewers

Assignees

knabben commented Oct 26, 2021 •

edited

Loading

vuil commented Oct 28, 2021 •

edited

Loading

knabben commented Nov 15, 2021 •

edited

Loading