Skip to content

vdk-control-cli: uncomment secrets test #3240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
duyguHsnHsn merged 2 commits into from
Mar 20, 2024
Merged

vdk-control-cli: uncomment secrets test #3240

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10ad17b
vdk-control-cli: uncomment secrets test
Mar 19, 2024
9a01e1a
Merge branch 'main' into person/mdilyan/uncomment-control-cli-test
duyguHsnHsn Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions projects/vdk-plugins/vdk-plugin-control-cli/tests/test_secrets_plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,11 @@ def test_secrets_plugin_no_url_configured():
):
runner = CliEntryBasedTestRunner(vdk_plugin_control_cli, secrets_plugin)

# TODO: Uncomment this after vdk-core release
# result: Result = runner.invoke(
# ["run", jobs_path_from_caller_directory("simple-job")]
# )
# # job that doesn't explicitly use secrets should fail due to secrets overrides in core
# cli_assert_equal(1, result)
result: Result = runner.invoke(
["run", jobs_path_from_caller_directory("simple-job")]
)
# job that doesn't explicitly use secrets should fail due to secrets overrides in core
cli_assert_equal(1, result)

result: Result = runner.invoke(
["run", jobs_path_from_caller_directory("secrets-job")]
Expand Down