Skip to content

verify dependencies between subpkgs#45504

Merged
sgn merged 7 commits into
void-linux:masterfrom
sgn:gen-rt-deps-subpkg
Aug 30, 2023
Merged

verify dependencies between subpkgs#45504
sgn merged 7 commits into
void-linux:masterfrom
sgn:gen-rt-deps-subpkg

Conversation

@sgn
Copy link
Copy Markdown
Member

@sgn sgn commented Aug 9, 2023

Testing the changes

  • I tested the changes in this PR: briefly

With those threads on reddit about unable to use libreoffice to generate epub, then a note to revbump libreoffice when poppler is rebuilt.

This solution hopefully is not too stupid.

Expect problem to come:

  • A package that would be build multiple time for multiple configuration. (Says emacs or Cataclysm-DDA), not sure how that would work. We may pick the first package that provides the shared library without SONAME. I don't know.

[ci skip][skip ci]

@sgn sgn added the xbps-src xbps-src related label Aug 9, 2023
@sgn sgn requested a review from a team August 9, 2023 12:58
@sgn sgn force-pushed the gen-rt-deps-subpkg branch from df08ed2 to 1cdb303 Compare August 16, 2023 13:05
@Duncaen
Copy link
Copy Markdown
Member

Duncaen commented Aug 16, 2023

This seems like a good idea.

There is also the case where we add libGLESv2.so discord-0.0.7_1 for a bunch of nonfree packages in common/shlibs.

This seems somewhat related since some non-free packages either do this or use noverifyrdeps=yes. Does this also solve this issue or is it possible to also solve that with this PR?

@sgn sgn force-pushed the gen-rt-deps-subpkg branch from 1cdb303 to 8ab52f9 Compare August 17, 2023 00:08
@sgn
Copy link
Copy Markdown
Member Author

sgn commented Aug 17, 2023

There is also the case where we add libGLESv2.so discord-0.0.7_1 for a bunch of nonfree packages in common/shlibs.

This seems somewhat related since some non-free packages either do this or use noverifyrdeps=yes. Does this also solve this issue or is it possible to also solve that with this PR?

Testing, But, yeah, IMO, it can be solved by this PR, or at least with a small change to this PR.

@sgn sgn force-pushed the gen-rt-deps-subpkg branch 2 times, most recently from 314bd54 to 8d40f5a Compare August 17, 2023 11:34
@sgn sgn force-pushed the gen-rt-deps-subpkg branch from 8d40f5a to e25e503 Compare August 29, 2023 06:18
sgn added 7 commits August 29, 2023 22:16
In a later change, we will generate shlib-depends cross subpkgs during
pre-pkg stage.  Thus we need shlib-provides information of all subpkgs
ready before pre-pkg is run.

Those information can only be read in post-install stage at the
eariliest.

Let's move the shlib-provides to post-install.  This hook requires
prepare-32bit, so, let's move that hook, too.
In a later change, we would like to generate runtime-deps between
sub-packages.

In order to do that, we can add everything into etc/shlibs or we can
look into other subpackages directly.  The former is cumbersome if such
package has lot of shared-objects.  The latter requires traversing and
checking a lot of files.  Furtunately, we can speed up the latter one by
storing all shared-objects' information in a centralised place.
@sgn sgn force-pushed the gen-rt-deps-subpkg branch from e25e503 to 191fdaa Compare August 29, 2023 15:16
@sgn sgn merged commit bd6ba85 into void-linux:master Aug 30, 2023
@sgn sgn deleted the gen-rt-deps-subpkg branch August 30, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

xbps-src xbps-src related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants