Describe the bug
discovered when playing around in nuxt/nuxt... (I tried to run vp run --filter './packages/**' prepack where nuxt depends on @nuxt/vite-builder and @nuxt/vite-builder has nuxt as a peer dep...)
the issue seems to be that vp run --filter includes devDependencies and peerDependencies in its dep graph...
(I think pnpm and turbo only follow dependencies for build order.)
Reproduction
https://github.com/danielroe/vp-cycle-repro
Steps to reproduce
pnpm install
pnpm --filter './packages/**' build # succeeds in topological order
vp run --filter './packages/**' build # → error: Cycle dependency detected: app#build -> builder#build -> app#build
pnpm install warns about the cyclic workspace links but still completes; the build itself runs fine.
System Info
vp 0.1.21, pnpm 11.0.9, macOS arm64.
Used Package Manager
pnpm
Logs
❯ vp run --filter './packages/**' build
VITE+ - The Unified Toolchain for the Web
error: Cycle dependency detected: app#build -> builder#build -> app#build
Validations
Describe the bug
discovered when playing around in nuxt/nuxt... (I tried to run
vp run --filter './packages/**' prepackwherenuxtdepends on@nuxt/vite-builderand@nuxt/vite-builderhasnuxtas a peer dep...)the issue seems to be that
vp run --filterincludesdevDependenciesandpeerDependenciesin its dep graph...(I think pnpm and turbo only follow
dependenciesfor build order.)Reproduction
https://github.com/danielroe/vp-cycle-repro
Steps to reproduce
pnpm install warns about the cyclic workspace links but still completes; the build itself runs fine.
System Info
Used Package Manager
pnpm
Logs
Validations