fix(cli): make env shims use the active vp executable#1631
Open
leohara wants to merge 6 commits into
Open
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
9c531d4 to
f4b525c
Compare
4 tasks
This comment was marked as off-topic.
This comment was marked as off-topic.
Member
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
nekomoyi
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Unix env shims created by
vp env setupso they point to the activevpexecutable instead of always assuming the standaloneVP_HOME/current/bin/vplayout.This keeps the existing standalone behavior when the active executable is
VP_HOME/current/bin/vp, while making Homebrew-style installs work whenvplives outsideVP_HOME.Fixes #1572 .
Details
vp../current/bin/vpfor standalone installsvpand verifies:vpcommand -v noderesolves to the Vite+ shimnode -vuses the project Node versionNote
This PR intentionally keeps the scope focused on
vp env setupcore shims. I noticed that package binary shims created byvp install -galso use the../current/bin/vpUnix target today, but I left that out to keep this PR focused on the reported Homebrewnodeshim issue. If you’d prefer fixing those package shims in the same PR, I’m happy to add that follow-up change here.Verification
cargo test -p vite_global_cli shim -- --nocapturepnpm bootstrap-clipnpm -C packages/cli snap-test-global command-env-setup-external-vpvp check --fixcargo clippy -p vite_global_cli --all-targetscargo fmt --checkgit diff --check