fix(cli): fix tsgolint path resolution for yarn install#360
Merged
Brooooooklyn merged 1 commit intoDec 23, 2025
Merged
Conversation
fengmk2
changed the title
fengmk2
changed the title
fengmk2
changed the title
Brooooooklyn
approved these changes
Dec 23, 2025
fengmk2
commented
Dec 23, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses tsgolint binary path resolution issues with yarn installations by adding platform-specific logic and existence checks. The changes aim to fix a bug where the tsgolint executable path was incorrectly resolved, particularly on Windows systems.
Key Changes:
- Added
existsSyncimport for file validation - Implemented platform-specific path resolution for Windows (using
.cmdextension and localnode_modules/.bin) - Added fallback logic to search in current working directory's
node_modules/.binon Windows - Simplified environment variable assignment by moving platform-specific logic into path resolution
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fengmk2
force-pushed
the
12-23-fix_cli_fallback_to_cwd_s_node_modules_to_find_tsgolint
branch
from
d7e2b92 to
2a8aef1
Compare
fengmk2
force-pushed
the
12-23-fix_cli_fallback_to_cwd_s_node_modules_to_find_tsgolint
branch
from
2a8aef1 to
8100086
Compare
Member
Author
Merge activity
|
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Brooooooklyn
deleted the
12-23-fix_cli_fallback_to_cwd_s_node_modules_to_find_tsgolint
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
existsSyncimport fromnode:fsto check if files existoxlint-tsgolint/bin/tsgolintfor non-Windows platformsnode_modules/.bindirectorynode_modules/.binif not foundyarn lint Failed to find tsgolint executable: OXLINT_TSGOLINT_PATH points to '~/rollipop/node_modules/@voidzero-dev/vite-plus/node_modules/.bin/tsgolint' which does not exist