Feature: add listview rebuild + cleanup#4819
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking Issue: #4699
Adds a
rebuildmethod onListViewArraythat allows us to rebuild the array to specific shapes that we want (via aListViewRebuildModeenum).This will make it easier to implement an optimization (that we are tentatively calling
IsZeroCopyToList) that tells us theListViewArrayhas no gaps nor overlaps from the views into theelementsbuffer, and that the views are all sorted and in order.I also added an unimplemented
OverlapCompressionrebuild mode if we ever want to do that.Also does some cleanup of other
ListViewfunctionality.