Chore: fix from_iter impls in vectors#5075
Conversation
Codecov Report❌ Patch coverage is
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ffcefe3 to
5d063e0
Compare
CodSpeed Performance ReportMerging #5075 will degrade performances by 37.81%Comparing Summary
Benchmarks breakdown
Footnotes
|
dc6e18a to
4664d11
Compare
|
So there is a huge regression on the microbenchmark when we switch to only using the lower bound. Not sure how much I trust microbenchmarks, but I do expect this given the amount of allocations we have to do for each of those sizes (up to 2^16 which means 15 allocations) |
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
12a8c0e to
871effe
Compare
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
871effe to
93d9b90
Compare
Didn't make it into the last one by accident