Skip to content

Chore: fix from_iter impls in vectors#5075

Merged
gatesn merged 2 commits into
developfrom
ct/vv-from-iter-fix
Oct 27, 2025
Merged

Chore: fix from_iter impls in vectors#5075
gatesn merged 2 commits into
developfrom
ct/vv-from-iter-fix

Conversation

@connortsui20

Copy link
Copy Markdown
Member

Didn't make it into the last one by accident

@connortsui20 connortsui20 added the changelog/chore A trivial change label Oct 24, 2025
@codecov

codecov Bot commented Oct 24, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.32258% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.57%. Comparing base (10a2c86) to head (93d9b90).
⚠️ Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-buffer/src/bit/buf_mut.rs 78.57% 3 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@connortsui20 connortsui20 mentioned this pull request Oct 24, 2025
39 tasks
Comment thread vortex-vector/src/bool/from_iter.rs Outdated
@connortsui20 connortsui20 force-pushed the ct/vv-from-iter-fix branch 2 times, most recently from ffcefe3 to 5d063e0 Compare October 27, 2025 14:32
@connortsui20 connortsui20 requested a review from gatesn October 27, 2025 14:32
@codspeed-hq

codspeed-hq Bot commented Oct 27, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #5075 will degrade performances by 37.81%

Comparing ct/vv-from-iter-fix (93d9b90) with develop (10a2c86)1

Summary

⚡ 4 improvements
❌ 4 regressions
✅ 1310 untouched
🆕 7 new
⏩ 22 skipped2

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
patched_take_200k_dispersed 5.7 ms 4.7 ms +19.76%
patched_take_200k_first_chunk_only 5.4 ms 4.8 ms +11.89%
take_200k_dispersed 4.6 ms 3.7 ms +23.71%
take_200k_first_chunk_only 4.3 ms 3.4 ms +25.65%
from_iter[BitBuffer, 1024] 7.1 µs 8.7 µs -18.09%
from_iter[BitBuffer, 16384] 41.3 µs 64.2 µs -35.67%
from_iter[BitBuffer, 2048] 9.3 µs 12.3 µs -24.31%
from_iter[BitBuffer, 65536] 150 µs 241.1 µs -37.81%
🆕 decompress[("alp_for_bp_f64", 0x782350)] N/A 24.2 ms N/A
🆕 decompress[("datetime_for_bp", 0x785630)] N/A 34.9 ms N/A
🆕 decompress[("dict_fsst_varbin_bp_string", 0x784740)] N/A 14.5 ms N/A
🆕 decompress[("dict_fsst_varbin_string", 0x7840b0)] N/A 14.5 ms N/A
🆕 decompress[("dict_varbinview_string", 0x782d70)] N/A 14.7 ms N/A
🆕 decompress[("for_bp_u64", 0x781c00)] N/A 2.5 ms N/A
🆕 decompress[("runend_for_bp_u32", 0x783200)] N/A 2 ms N/A

Footnotes

  1. No successful run was found on develop (e570ee4) during the generation of this report, so 10a2c86 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 22 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@connortsui20 connortsui20 force-pushed the ct/vv-from-iter-fix branch 2 times, most recently from dc6e18a to 4664d11 Compare October 27, 2025 15:32
@connortsui20

connortsui20 commented Oct 27, 2025

Copy link
Copy Markdown
Member Author

So there is a huge regression on the microbenchmark when we switch to only using the lower bound. Not sure how much I trust microbenchmarks, but I do expect this given the amount of allocations we have to do for each of those sizes (up to 2^16 which means 15 allocations)

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20 connortsui20 force-pushed the ct/vv-from-iter-fix branch 3 times, most recently from 12a8c0e to 871effe Compare October 27, 2025 16:27
Comment thread vortex-mask/src/lib.rs Outdated
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@gatesn gatesn enabled auto-merge (squash) October 27, 2025 16:48
@gatesn gatesn disabled auto-merge October 27, 2025 16:49
@gatesn gatesn merged commit 66844f2 into develop Oct 27, 2025
38 of 40 checks passed
@gatesn gatesn deleted the ct/vv-from-iter-fix branch October 27, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants