Skip to content

Remove the full analysis from benchmark comments #8233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AdamGS merged 1 commit into from
Jun 3, 2026
Merged

Remove the full analysis from benchmark comments #8233

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 0 additions & 31 deletions scripts/compare-benchmark-jsons.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -783,22 +783,6 @@ def main() -> None:
print("---")
print("")

if statistical_analysis is not None:
alpha_rows = statistical_analysis["detail_df"][~statistical_analysis["detail_df"]["is_control"]].copy()
if not alpha_rows.empty:
alpha_rows = alpha_rows.sort_values(["query", "engine", "file_format"])
alpha_table = pd.DataFrame(
{
"Query": alpha_rows["query"].astype(int),
"Config": alpha_rows["combo"],
"Raw Δ": alpha_rows["ratio"].map(format_ratio_change),
"Control Δ": alpha_rows["beta_ratio"].map(format_ratio_change),
"Attributed α": alpha_rows["alpha_ratio"].map(format_ratio_change),
"Noise floor": alpha_rows["noise_floor_ratio"].map(format_ratio_change),
"Significant?": alpha_rows["signal"].map(format_signal),
}
)

grouped_tables = df3.groupby(["engine", "file_format"], dropna=False, sort=False)
for engine, file_format in sorted(grouped_tables.groups.keys(), key=group_sort_key):
group_df = grouped_tables.get_group((engine, file_format)).sort_values("name")
Expand Down Expand Up @@ -847,21 +831,6 @@ def main() -> None:
print("")
print(file_size_report)

if statistical_analysis is not None and not alpha_rows.empty:
print("<details>")
print("<summary>Full attributed analysis</summary>")
print("")
print("<br>")
print("")
print(
alpha_table.to_markdown(
index=False,
tablefmt="github",
)
)
print("")
print("</details>")


if __name__ == "__main__":
main()
Loading