Migrate to new stats falsification rules#8345
Merged
Merged
Conversation
AdamGS
added a commit
that referenced
this pull request
Jun 11, 2026
## Summary Adds docs for `StatsRewriteRule` and its functions. Can be considered a follow-up for #8345, but can be individually merged. Signed-off-by: Adam Gutglick <adam@spiraldb.com>
gatesn
force-pushed
the
ngates/public-stats-rewrite-rules
branch
from
033c73f to
5ed375f
Compare
Port file pruning to session stats rewrites Signed-off-by: "Nicholas Gates" <nick@nickgates.com> Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: "Nicholas Gates" <nick@nickgates.com> Signed-off-by: Nicholas Gates <nick@nickgates.com>
gatesn
force-pushed
the
ngates/public-stats-rewrite-rules
branch
from
5ed375f to
e8dd011
Compare
Merging this PR will not alter performance
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | take_10k_random |
197.9 µs | 255.5 µs | -22.53% |
| ❌ | Simulation | take_10k_contiguous |
218.5 µs | 275.6 µs | -20.72% |
| ❌ | Simulation | patched_take_10k_contiguous_patches |
232.2 µs | 290.9 µs | -20.17% |
| ❌ | Simulation | patched_take_10k_random |
244.2 µs | 303.4 µs | -19.51% |
| ❌ | Simulation | chunked_varbinview_opt_canonical_into[(1000, 10)] |
178 µs | 213.2 µs | -16.53% |
| ❌ | Simulation | chunked_varbinview_opt_into_canonical[(1000, 10)] |
193.4 µs | 229.3 µs | -15.67% |
| ❌ | Simulation | decompress_rd[f64, (100000, 0.01)] |
890.6 µs | 1,024.5 µs | -13.07% |
| ❌ | Simulation | decompress_rd[f64, (100000, 0.1)] |
890.6 µs | 1,024.5 µs | -13.07% |
| ⚡ | Simulation | chunked_varbinview_canonical_into[(1000, 10)] |
198.5 µs | 162.7 µs | +21.99% |
| ⚡ | Simulation | varbinview_large |
130.4 µs | 112.6 µs | +15.81% |
| ⚡ | Simulation | chunked_varbinview_canonical_into[(100, 100)] |
308.7 µs | 273.6 µs | +12.81% |
| ⚡ | Simulation | chunked_varbinview_into_canonical[(100, 100)] |
367.7 µs | 332.5 µs | +10.57% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing ngates/public-stats-rewrite-rules (3e7c2d6) with develop (98d4a6a)
Signed-off-by: "Nicholas Gates" <nick@nickgates.com> Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: "Nicholas Gates" <nick@nickgates.com> Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: "Nicholas Gates" <nick@nickgates.com> Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
gatesn
changed the title
Signed-off-by: Nicholas Gates <nick@nickgates.com>
AdamGS
reviewed
Jun 12, 2026
AdamGS
reviewed
Jun 12, 2026
| use crate::scalar::Scalar; | ||
| use crate::scalar_fn::fns::stat::StatFn; | ||
|
|
||
| /// A target that can bind abstract statistics to concrete expressions. |
Contributor
There was a problem hiding this comment.
What does it mean to bind a statistic to an expression? What makes statistics abstract?
Contributor
Author
There was a problem hiding this comment.
What does it mean to bind a statistic to an expression? What makes statistics abstract?
Yeah stats stuff I am intermingling with an expressions change, so I think the "stat" expression becomes explicitly an "Expression::Placeholder", meaning it must be replaced prior to execution.
It's the same logic as our StatCatalog. Except the current StatCatalog means you have to re-run falsification over the entire expression any time your stats come from a different place, e.g. FileStats vs ZoneMap vs ArrayStats.
Here you take the falsified expression, then "bind" the stats from wherever you get them from.
AdamGS
reviewed
Jun 12, 2026
| @@ -115,14 +119,52 @@ impl FileStatsLayoutReader { | |||
| Ok(result.as_bool().value() == Some(true)) | |||
| refs | ||
| } | ||
|
|
||
| fn collect_referenced_stat_field_names(expr: &Expression, refs: &mut HashSet<FieldName>) { |
Contributor
There was a problem hiding this comment.
we have Node implemented for Expression, you should be able to visit the tree using that instead of hand-rolling the recursion
| } | ||
| } | ||
|
|
||
| fn bool_literal(expr: &Expression) -> Option<Option<bool>> { |
| return Ok(None); | ||
| }; | ||
| let required_stats = filter_required_stats(&lowered, binder.required_stats); | ||
| if required_stats.map().is_empty() && !matches!(bool_literal(&lowered), Some(Some(true))) { |
Contributor
There was a problem hiding this comment.
maybe add a comment explaining this if statement?
| available_stats, | ||
| required_stats: Relation::new(), | ||
| }; | ||
| let Some(lowered) = bind_stats(predicate, &mut binder)? else { |
Contributor
There was a problem hiding this comment.
Maybe I'm just stupid - but I think both "lowering" and "bindings" are worth defining and explaining somewhere.
Contributor
|
I think I mostly have a lot of questions 😅 |
Signed-off-by: "Nicholas Gates" <nick@nickgates.com>
github-actions
Bot
removed
the
action/benchmark
Contributor
Polar Signals Profiling ResultsLatest Run
Previous Runs (2)
Powered by Polar Signals Cloud |
Contributor
Benchmarks: PolarSignals ProfilingVortex (geomean): 1.009x ➖ How to read Verdict and Engines
datafusion / vortex-file-compressed (1.009x ➖, 0↑ 2↓)
No file size changes detected. |
Contributor
Benchmarks: TPC-H SF=1 on NVMEVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.943x ➖, 2↑ 0↓)
datafusion / vortex-compact (0.938x ➖, 1↑ 0↓)
datafusion / parquet (0.945x ➖, 2↑ 0↓)
datafusion / arrow (0.938x ➖, 3↑ 0↓)
duckdb / vortex-file-compressed (0.954x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.954x ➖, 1↑ 1↓)
duckdb / parquet (0.945x ➖, 4↑ 0↓)
duckdb / duckdb (0.963x ➖, 0↑ 0↓)
File Size Changes (10 files changed, +2.2% overall, 9↑ 1↓)
Totals:
|
Contributor
Benchmarks: FineWeb NVMeVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.000x ➖, 0↑ 0↓)
datafusion / vortex-compact (1.000x ➖, 1↑ 0↓)
datafusion / parquet (1.013x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (0.946x ➖, 1↑ 0↓)
duckdb / vortex-compact (1.042x ➖, 0↑ 2↓)
duckdb / parquet (1.002x ➖, 0↑ 0↓)
File Size Changes (2 files changed, -0.1% overall, 0↑ 2↓)
Totals:
|
Signed-off-by: "Nicholas Gates" <nick@nickgates.com>
github-actions
Bot
removed
the
action/benchmark-sql
Signed-off-by: Nicholas Gates <nick@nickgates.com>
github-actions
Bot
removed
the
action/benchmark-sql
Signed-off-by: "Nicholas Gates" <nick@nickgates.com>
AdamGS
reviewed
Jun 18, 2026
| @@ -0,0 +1,199 @@ | |||
| // SPDX-License-Identifier: Apache-2.0 | |||
Contributor
|
I think a few commits from other branches made it here by mistake |
joseph-isaacs
requested changes
Jun 18, 2026
joseph-isaacs
left a comment
joseph-isaacs
left a comment
Contributor
There was a problem hiding this comment.
Almost there. I trust the other matches can we fuzz before merging.
Also needs to comments
|
|
||
| Vortex uses statistics to prove when a filter cannot match a row group, zone, or | ||
| file. The proof expression returns `true` when the input can be skipped. It | ||
| returns `false` or `null` when pruning is not proven. |
Contributor
There was a problem hiding this comment.
I think its just easier to map nulls to nulls
| #[derive(Clone)] | ||
| pub struct Binary; | ||
|
|
||
| fn simplify_and(lhs: &Expression, rhs: &Expression) -> Option<Expression> { |
joseph-isaacs
approved these changes
Jun 18, 2026
Signed-off-by: "Nicholas Gates" <nick@nickgates.com>
robert3005
reviewed
Jun 18, 2026
| @@ -0,0 +1,199 @@ | |||
| // SPDX-License-Identifier: Apache-2.0 | |||
Contributor
There was a problem hiding this comment.
The rebase seems wrong?
robert3005
reviewed
Jun 18, 2026
| `true`, the file stats reader can return an all-false pruning mask without | ||
| reading child layouts. | ||
|
|
||
| Scan planning uses `checked_pruning_expr` to lower a falsified expression against |
robert3005
reviewed
Jun 18, 2026
robert3005
reviewed
Jun 18, 2026
Signed-off-by: "Nicholas Gates" <nick@nickgates.com>
Signed-off-by: "Nicholas Gates" <nick@nickgates.com>
Signed-off-by: "Nicholas Gates" <nick@nickgates.com>
Signed-off-by: "Nicholas Gates" <nick@nickgates.com>
robert3005
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch over to using the new rewrite rule registry from the session, instead of using the scalar fn vtable.