Skip to content

Use DUCKDB_SOURCE_DIR if supplied #8363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
myrrc merged 1 commit into from
Jun 11, 2026
Merged

Use DUCKDB_SOURCE_DIR if supplied #8363

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 28 additions & 7 deletions vortex-duckdb/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,17 +397,40 @@ fn cbindgen_rust2c(crate_dir: &Path) {
}

fn main() {
println!("cargo:rerun-if-env-changed=DUCKDB_VERSION");
println!("cargo:rerun-if-changed=cpp/include");
println!("cargo:rerun-if-env-changed=VX_DUCKDB_DEBUG");
println!("cargo:rerun-if-env-changed=VX_DUCKDB_SAN");
println!("cargo:rerun-if-env-changed=CARGO_HTTP_TIMEOUT");
println!("cargo:rerun-if-env-changed=HTTP_TIMEOUT");
println!("cargo:rerun-if-env-changed=TARGET");

// `DUCKDB_VERSION` is set by the extension build in CI.
// This is to ensure we don't implicitly build against a different DuckDB
// version during an extension build which might lead to subtle ABI breaks,
// e.g. reordering fields in C++ structs.
// These two variables are set in duckdb-vortex's CI. Don't download
// duckdb if they are present
println!("cargo:rerun-if-env-changed=DUCKDB_SOURCE_DIR");
println!("cargo:rerun-if-env-changed=DUCKDB_VERSION");

// sanity check that either none or both are provided
assert_eq!(
env::var("DUCKDB_VERSION").is_ok(),
env::var("DUCKDB_SOURCE_DIR").is_ok()
);
// If variables are not set, we are either running locally or
// in vortex's CI.

let crate_dir = PathBuf::from(env::var("CARGO_MANIFEST_DIR").unwrap());
if let Some(source_dir) = env::var_os("DUCKDB_SOURCE_DIR") {
let source_dir = PathBuf::from(source_dir);
let duckdb_include_dir = source_dir.join("src").join("include");
println!(
"cargo:info=Using DuckDB source from DUCKDB_SOURCE_DIR={}",
source_dir.display()
);
bindgen_c2rust(&crate_dir, &duckdb_include_dir);
cbindgen_rust2c(&crate_dir);
compile_cpp(&duckdb_include_dir);
return;
}

let version = env::var("DUCKDB_VERSION")
// You can also change this version to a commit hash
.unwrap_or_else(|_| DEFAULT_DUCKDB_VERSION.to_owned());
Expand All @@ -417,7 +440,6 @@ fn main() {
DuckDBVersion::Commit(c) => println!("cargo:info=Using DuckDB commit: {c}"),
}

let crate_dir = PathBuf::from(env::var("CARGO_MANIFEST_DIR").unwrap());
let duckdb_dir = crate_dir.join("duckdb");
let out_dir = PathBuf::from(env::var("OUT_DIR").unwrap());
let library_dir = out_dir.join(format!("duckdb-lib-{version}"));
Expand Down Expand Up @@ -486,7 +508,6 @@ fn main() {
};

let duckdb_include_dir = inner_dir.join("src").join("include");
println!("cargo:rerun-if-changed=cpp/include");
bindgen_c2rust(&crate_dir, &duckdb_include_dir);
cbindgen_rust2c(&crate_dir);
compile_cpp(&duckdb_include_dir);
Expand Down
Loading