Problem with Package defaults warning

[zipkid]

as of puppet 3.6.1 there is a deprecation warning.
https://docs.puppetlabs.com/puppet/3.6/reference/release_notes.html#changes-to-rpm-behavior-with-virtual-packages

When using this puppet-python module setting this does not remove the warning as it should.

This is caused by the creation of a package resource in the 3 facts included in the module.
https://github.com/stankevich/puppet-python/blob/master/lib/facter/pip_version.rb#L4
pkg = Puppet::Type.type(:package).new(:name => "python-pip")

[neilkatin]

See also this ticket: https://tickets.puppetlabs.com/browse/PUP-2974, which seems to describe the same problem.

[shivapoudel]

@neilkatin and @zipkid I have quiet busy schedule at the moment. Coming week I'll see what this issue is about :)

[KlavsKlavsen]

just found that those two facts gives me the same warnings :(

[treydock]

+1. Running Puppet 3.6.2 and Puppet apply (masterless nodes) all generate the warning.

[eshamow]

+1 seeing this on 3.7.2.

[shivapoudel]

@eshamow Thanks for this :)

[shivapoudel]

Seems like we should mark this issue as solved. If anybody finds this as unsolved they please do report to open this issue

[KlavsKlavsen]

one note - this breaks puppet < 3.6 (since they do not have allow_virtual option.
in defaults.pp I check for puppetversion - before setting this, so that should be done here as well.

[eshamow]

@KlavsKlavsen agreed - will look into this and file another PR to resolve - @shivapoudel we should probably re-open.