Skip to content

new manage_requirements argument to address issue 273#274

Merged
shivapoudel merged 2 commits into
voxpupuli:masterfrom
rosenbergj:issue-273
Dec 15, 2015
Merged

new manage_requirements argument to address issue 273#274
shivapoudel merged 2 commits into
voxpupuli:masterfrom
rosenbergj:issue-273

Conversation

@rosenbergj
Copy link
Copy Markdown

No description provided.

@rosenbergj
Copy link
Copy Markdown
Author

(My first ever pr; please be gentle...)

@ghoneycutt
Copy link
Copy Markdown
Member

@rosenbergj thanks for contributing!

Comment thread manifests/requirements.pp
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs to be documented in the README.md

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@rosenbergj rosenbergj force-pushed the issue-273 branch 2 times, most recently from f2d5e72 to 42afd0d Compare December 7, 2015 15:49
@ghoneycutt
Copy link
Copy Markdown
Member

Looks good. We also need some spec tests - See https://github.com/stankevich/puppet-python/blob/master/spec/defines/requirements_spec.rb

Add a block where you let params set manage_requirements to false and it should test that the file $requirements is not in the catalog

context "/requirements.txt" do
        let (:params) {{ :requirements => "/requirements.txt", :manage_requirements => false }}
        it { is_expected.not_to contain_file("/requirements.txt") }
      end

shivapoudel pushed a commit that referenced this pull request Dec 15, 2015
new manage_requirements argument to address issue 273
@shivapoudel shivapoudel merged commit 0d08d4e into voxpupuli:master Dec 15, 2015
@rosenbergj
Copy link
Copy Markdown
Author

Thank you!

@rosenbergj rosenbergj deleted the issue-273 branch December 15, 2015 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants