Add support, tests and documentation for Gentoo#335
Conversation
| :id => 'root', | ||
| :kernel => 'Linux', | ||
| :osfamily => 'Gentoo', | ||
| :operatingsystem => 'Gentoo', |
There was a problem hiding this comment.
you must specify :lsbdistcodename here for TravisCI to be happy.
https://travis-ci.org/stankevich/puppet-python/jobs/166102244
|
Thanks for adding Gentoo support. The code looks good and once the tests are passing, this should be able to be merged. |
|
Thanks @ghoneycutt, I saw that it had failed but didn't yet find the time to investigate, thanks for pointing me directly at the fix. I've pushed this change (lsbdistcodename shows up as "n/a" for me on my system, so that's what I've used for the test). Looks like travis-ci timed out on all the ruby-2.3.1 builds, but working for all previous releases. I don't think that's a result of my code changes? The output seems to stop while running the Debian tests. |
|
Yeah, that's not related to this. Could you please squash your commits and I'll do a merge and release tomorrow. |
optiz0r
force-pushed
the
feature_gentoo
branch
from
4be8909 to
6ff5077
Compare
|
@ghoneycutt squashed and hopefully ready to go! |
|
Thank you! Released in 1.18.0 |
2 participants
No description provided.