Improve support for pip on CentOS7/EPEL

[ju5t]

Due to a recent change in EPEL the python-pip package was renamed to python2-pip. This currently breaks this module on CentOS 7. This commit makes sure that it defaults to python2-pip if the system is running Python 2 on CentOS 7 when using EPEL.

[aschaber1]

I disabled use_epel since I have manage it elsewhere, but still would like this case to apply, which is why I like #349 better.

[ju5t]

I probably misinterpreted $use_epel when writing this. I'll remove it.

As far as #349 is concerned: it doesn't do any spec tests and uses a regex on a fact that can be done cheaper and more effectively with versioncmp() and $::operatingsystemmajrelease.

[ghoneycutt]

awesome work, thank you!

Would you mind adding a case for RedHat 6, that shows the same thing as this, but with the correct pip package name and update the existing RedHat 5 part with the name attribute. That would give us much better testing for all use cases with EL.

[ju5t]

I've pushed a change that adds tests for 6 and tests the name on 5 too.

I would suggest rewriting the spec tests at some point so there isn't that much divergence between the different operating systems. E.g.

require 'spec_helper'
describe 'python', :type => :class do
  context 'supported operating systems' do
    on_supported_os.each do |os, facts|
      context "on #{os}" do

Something for the future.

[ghoneycutt]

@aschaber1 We need a third party to validate that this code actually works on EL7. Would you be able to do that and report back?

[aschaber1]

@ghoneycutt, just tried it: works.

$ puppet agent -t --environment integration_python_pipfix
Info: Using configured environment 'integration_python_pipfix'
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Loading facts
Info: Caching catalog for $FQDN
Info: Applying configuration version '49315315c4582938518434a20cc6bacd3e9d38da'
Notice: /Stage[main]/Python::Install/Package[pip]/ensure: created
Notice: Applied catalog in 16.47 seconds

RPM Output:

# rpm -qa | grep pip
python2-pip-8.1.2-5.el7.noarch

facterversion => 3.5.0
os.family => RedHat
os.name => CentOS
os.release => {
  full => "7.3.1611",
  major => "7",
  minor => "3"
}
puppetversion => 4.8.1

[ghoneycutt]

Thank you!

[ghoneycutt]

Released in 1.18.2

[wyardley]

I don't see python3-xxx (including python3-pip) available on CentOS7, even with epel repo enabled, though I do see python34-pip via our EPEL mirror. It's also not clear to me that this would help, even with python2-pip absent and python34-pip present, seems to me like the module is still hard-coded to use "pip".

Some additional comments in #303.

[ju5t]

This pull request only solved an issue where packages were renamed by EPEL. What you're describing is a different issue. I think it would be better to discuss this in #303.