Skip to content

add pip support for setuptools extras#390

Merged
stankevich merged 1 commit into
voxpupuli:masterfrom
bryangwilliam:pip_extras
May 9, 2018
Merged

add pip support for setuptools extras#390
stankevich merged 1 commit into
voxpupuli:masterfrom
bryangwilliam:pip_extras

Conversation

@bryangwilliam
Copy link
Copy Markdown
Contributor

This PR adds support for installing setuptools extras (https://packaging.python.org/tutorials/installing-packages/#installing-setuptools-extras).

I believe this change can resolve #284 and #218 by changing the declaration from

python::pip { 'somePackage[extra]': }

to

python::pip { 'somePackage': 
  extras => [extra],
}

@stankevich stankevich merged commit 7e7cf2d into voxpupuli:master May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot determine if a package named in the form packagename[subfeature] is installed.

2 participants