Skip to content

Add support for Anaconda#409

Merged
bastelfreak merged 1 commit into
voxpupuli:masterfrom
jb-abbadie:anaconda
Jun 25, 2018
Merged

Add support for Anaconda#409
bastelfreak merged 1 commit into
voxpupuli:masterfrom
jb-abbadie:anaconda

Conversation

@jb-abbadie
Copy link
Copy Markdown
Contributor

Pull Request (PR) description

This PR adds support for the anaconda distribution of python (https://www.anaconda.com/)

@jb-abbadie jb-abbadie force-pushed the anaconda branch 3 times, most recently from 594bbb6 to b123cce Compare June 10, 2018 08:49
Comment thread manifests/init.pp Outdated
Boolean $use_epel = $python::params::use_epel,
$rhscl_use_public_repository = $python::params::rhscl_use_public_repository,
String $anaconda_installer_url = $python::params::anaconda_installer_url,
String $anaconda_install_path = $python::params::anaconda_install_path,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be a Stdlib::Absolutepath?

Comment thread manifests/init.pp Outdated
Hash $python_dotfiles = { },
Boolean $use_epel = $python::params::use_epel,
$rhscl_use_public_repository = $python::params::rhscl_use_public_repository,
String $anaconda_installer_url = $python::params::anaconda_installer_url,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be a Stdlib::Httpurl?

Comment thread manifests/virtualenv.pp
$extra_pip_args = '',
$virtualenv = undef
) {
include ::python
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason this isn't needed anymore?

@othalla
Copy link
Copy Markdown

othalla commented Jun 20, 2018

Dear maintainers, any update about this enhancement?

@bastelfreak bastelfreak added the enhancement New feature or request label Jun 25, 2018
@bastelfreak
Copy link
Copy Markdown
Member

Thanks for the PR @grsakea !

@bastelfreak bastelfreak merged commit 969bfca into voxpupuli:master Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants