Skip to content

Fix Python version regex in install.pp #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wyardley merged 1 commit into from
Jun 16, 2018
Merged

Fix Python version regex in install.pp #410

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion manifests/install.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@
}
}

if "${::python::version}" =~ /^3/ { #lint:ignore:only_variable_string
if "${::python::version}" =~ /^python3/ { #lint:ignore:only_variable_string
Copy link
Copy Markdown
Contributor

@wyardley wyardley Jun 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the lint ignore, but wonder if there's any reason this can't / shouldn't just be
if $python::version =~ /^python3/

$pip_category = undef
$pip_package = 'python3-pip'
} elsif ($::osfamily == 'RedHat') and (versioncmp($::operatingsystemmajrelease, '7') >= 0) {
Expand Down