Pip: freeze all to be able to control setuptools, distribute, wheel, pip

[Feandil]

Pull Request (PR) description

By default pip freeze skip the mentioned packages and only displays their version if --all is used.
As a result, the following code would result in puppet trying to update the pip package every time:

    python::pip { 'update-pip' :
      ensure     => '10.0.1',
      pkgname    => 'pip',
      virtualenv => $virtualenv,
    }

Notice: /Stage[main]/.../Python::Pip[update-pip]/Exec[pip_install_update-pip]/returns: executed successfully

With this patch, this recurrent change disappears.

I've added --all to all cases, but only tested my own use case...

[bastelfreak]

Hi @Feandil, thanks for the PR. I would like to wait with merging it until #419 is done.

[danquack]

Is there any rspec tests that can be written to catch this from being regressed?

[bastelfreak]

@Feandil can you please rebase and add an acceptance test for this change?

[Feandil]

Sorry, I was away for a few weeks...

I've rebased on master and cut the regression test in two. Adding the fix, this makes it 3 commits:

• c76c9b4 is the basic installation: it works with the existing code
• bbb85bf check that puppet doesn't try to install it on every run: it fails with the existing code
• 3c3ba03 is the fix I proposed

[bastelfreak]

thanks for the patch!